From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=iufKifsd;
 spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65])
 by groups.io with SMTP; Thu, 19 Sep 2019 03:00:16 -0700
Received: by mail-wm1-f65.google.com with SMTP id y135so6799726wmc.1
        for <devel@edk2.groups.io>; Thu, 19 Sep 2019 03:00:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=PIYQ3TEX9P8UryWLqPLoIbZVqFNW6fPqN7KRlG1h+rA=;
        b=iufKifsdFamWQlfMtgKT+/qKErUcrJyQaQnbjQm85KDP9OTHMZEv7ZnJYBONa56Bsg
         Jx0ggdxOo8/mR2SElu9plsAMEJrdY1HEO0DuDfiSAaf3fN0rHLX2vDucYClBpVZVw9zq
         ssxByGVvbnrcW8q85Z4Knim2eEfv5zkWGCzmZ+aupwKCyeHYBy3ZdRlerYqVBe36lX4a
         mxedbI/byDiwgXHb/Kc640cxmOanxwfcTSbEqMVCu5rbsizwKGyVLKBtA8fEzi8y9Ewg
         16HNPS8+OJm4cRla4gPTjkdBC4kLCv3bfFq9yu2iHmfm6pHCjf/S97HumKKwbOY1ldZX
         n0cg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=PIYQ3TEX9P8UryWLqPLoIbZVqFNW6fPqN7KRlG1h+rA=;
        b=WkkkQ79hYigvVYnpjVmOBE5W9Dyzov9QW79dmKSI3izxTm8wNB0qkNsyptt/3Ces5f
         5ZZnVq+/bmJg3oPXYbL14DHQ+CjevbSmQfIy/Tfk0Nd+hFccRUmJaN25plTVNzHZ+2lM
         r5ti/MPdn+LHnXnU1pI0JvBnzEUMcfv1y7wFRavap/HzsJJrc9pED6UngVM6JFm8IkN0
         EYZ8L7Boo9qG/cH7acyvbEbw+IdUsMAyPv2RH44uPQnEcphlbmjfRquNWfC+IHsgXpi5
         hZ4Xps8mVOTXK9CypQtq/a/8h8GoPgzH6aY4a68JxMRuGFKaOrKvZre0wT7YHljC+WP7
         TSLw==
X-Gm-Message-State: APjAAAU4HMSc3k2L2Z0dyfPpoUpCnI1C3YhD+KftfVSnaCcC81PAZWIF
	op4CvYbKWVU58oeHZbJJeSbexhYjDLLQlGZRyO6aig==
X-Google-Smtp-Source: APXvYqzl34iZZ0bTdDyoIJMhG7vVzc2TMza0IVqXtcW0TpFJmpJOYi7RtPeGyalBtJ5Lwg/i/qdbAn6HAuBEtnuBeEo=
X-Received: by 2002:a7b:cf37:: with SMTP id m23mr2107553wmg.53.1568887215033;
 Thu, 19 Sep 2019 03:00:15 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1568808805.git.baptiste.gerondeau@linaro.org>
 <b1f747083c3c354ea1b2348c80e7cc768f69490c.1568808805.git.baptiste.gerondeau@linaro.org>
 <CAKv+Gu-SJxSnYbQDNbE_B2i_37-MiVG5gKj9DkBkTwh12whSUw@mail.gmail.com> <20190919095204.GP28454@bivouac.eciton.net>
In-Reply-To: <20190919095204.GP28454@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 19 Sep 2019 12:59:47 +0300
Message-ID: <CAKv+Gu8TmNhuUFsCW--0PM4obhtUAyjQqZDGA46drQ3imxCTmg@mail.gmail.com>
Subject: Re: [PATCH 3/3] ARM/Assembler: Reuse RVCT assembler for MSFT build
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>, 
	edk2-devel-groups-io <devel@edk2.groups.io>, "Kinney, Michael D" <michael.d.kinney@intel.com>, 
	"Gao, Liming" <liming.gao@intel.com>, "Zhang, Shenglei" <shenglei.zhang@intel.com>, 
	Baptiste GERONDEAU <bgerondeau@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 19 Sep 2019 at 12:52, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Thu, Sep 19, 2019 at 12:38:00PM +0300, Ard Biesheuvel wrote:
> > On Wed, 18 Sep 2019 at 15:27, Baptiste Gerondeau
> > <baptiste.gerondeau@linaro.org> wrote:
> > >
> > > From: Baptiste GERONDEAU <bgerondeau@gmail.com>
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750"
> > >
> > > Since RVCT shares the same assembler syntax as MSFT, use .asm files
> > > and associate them with MSFT, which would be a first step to addressing
> > > the above Bugzilla issue.
> > > RVCT will also have to be erased from BaseTools/rest of the build
> > > infrastructure, to fully address BZ#1750 ; this patch only addresses the
> > > "code" in itself.
> > >
> > > Signed-off-by: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
> >
> > The changes look fine to me, but please split them out per package as
> > Liming suggested.
>
> Hmm, and I've just gone and contradicted that.
> As I said in my reply to Liming, this is a very special situation, and
> the net effect of splitting this patch up is that we end up with a
> set of not-usefully-bisectable patches.
>

Fair enough. I won't get involved in that discussion, though.