From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E35B2209831C4 for ; Sun, 24 Jun 2018 04:22:03 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id a195-v6so8543385itd.3 for ; Sun, 24 Jun 2018 04:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NuPE6ujDhhzJ/gb1ED156tn/ztAd9XoaXpL5fzqLcVM=; b=kejIGvUk9130kYYPgurE+fK/hUWlz+qEF7Lo885ALiDe2w2vfFF/Y5yu3v6EqBTO7K XGJoEeI0u2a1g2TZSEwE8sWExojbeOkj+LaFQsXx4OpuNpR38kLH+iXEOWnoFJ4rOgcT yBPrcRb0JVJ3LbCFljZdIsoUUF6jR5mrcY38Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NuPE6ujDhhzJ/gb1ED156tn/ztAd9XoaXpL5fzqLcVM=; b=A6uZ6pEcKV4czGymKDMg56dr7EJBLxqQxY+QigBcEaubl+x5SoL7kTJ/lNptORzEDD 4IykVqVBRe+IS4G8PiLotYbZP+OZZrZIj+a8wKXFZc2Ocmp9UYFMundVcefDKLCpFqOF kuwB3niaTv5durS99Z0+HuH/Z5RHh93uc2ZhSRHCgj/YvnF+rPZlr0nTMJb9yZgk+/hn KiYGv8jfRmR87MBVeL+xZxfVDGNz1FN7H6Fez28idUrPTLkJUm0OH59e+j0NXta7PtJd 8pNefTnpHst3ZQafMFHCJoBvdE6VTpVOVOLmPhlma+g16nYWCtJjBwyurrLMlXOLGjUX ffUA== X-Gm-Message-State: APt69E0pBwu7s/7pwo8mswxkQJi6+fai/YFRKobKcvZtz/dORdWRnj61 FxVZnVEBTnCCM4+xH6FurB59M6vqa4+ppswP7OusCw== X-Google-Smtp-Source: ADUXVKKxbSMXZflf/EbbBzyGAAmBEE9TrOOx2jfyhDcFjH6WZYBu+0RFBA+Im+HrkJpOJHcU/Q3bVx8ShjiUu+LiQ14= X-Received: by 2002:a24:6196:: with SMTP id s144-v6mr4578202itc.68.1529839322661; Sun, 24 Jun 2018 04:22:02 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Sun, 24 Jun 2018 04:22:02 -0700 (PDT) In-Reply-To: References: <20180328010531.GA69547@SZX1000114654> <20180329002050.GB97590@SZX1000114654> <20180331013747.GA106704@SZX1000114654> <20180413020553.GB119834@SZX1000114654> <20180416135709.GA122959@SZX1000114654> <20180417012044.GA123329@SZX1000114654> <20180622125801.GA2437@iwish> From: Ard Biesheuvel Date: Sun, 24 Jun 2018 13:22:02 +0200 Message-ID: To: gary guo Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Michael D Kinney , Haojian Zhuang Subject: Re: [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2018 11:22:04 -0000 Content-Type: text/plain; charset="UTF-8" On 22 June 2018 at 16:08, Ard Biesheuvel wrote: > On 22 June 2018 at 14:58, gary guo wrote: >> Sure. A little busy these days; I'll do that ASAP. >> > > No worries. > > BTW I noticed that we still have a problem with option ROMs when using > the new MMIO translation code. Did you look into that at all? > The option ROM code is fine as long as the PCI address of the MMIO32 region is > 0x0. Not sure what is going on here, but probably not worth the effort of digging into. > >> On Thu, Jun 07, 2018 at 01:11:59PM +0200, Ard Biesheuvel wrote: >>> On 17 April 2018 at 03:20, Guo Heyi wrote: >>> > Hi Ard, >>> > >>> > I tested mm -io on D05, for root bridge 4 with CPU IO address starting from >>> > 0x8_abff0000, and it worked; both mm -io 0x8abff0000 and mm 0x8abff0000 provided >>> > the same output. It seems there is no other limit for 64bit IO address after you >>> > fixed the issue in EFI shell mm command. >>> > >>> >>> OK, so I think this is fine after all, even if my uneasy feeling >>> hasn't gone away :-) >>> >>> Could you please resend the latest rebased version of the patches? >>> (and include the ATU fix as well) >>> >>> >>> > On Mon, Apr 16, 2018 at 09:57:09PM +0800, Guo Heyi wrote: >>> >> Thanks, I will test mm command and let you know the result. >>> >> >>> >> Regards, >>> >> >>> >> Heyi >>> >> >>> >> On Fri, Apr 13, 2018 at 09:19:53AM +0200, Ard Biesheuvel wrote: >>> >> > On 13 April 2018 at 04:05, Guo Heyi wrote: >>> >> > > Hi Ard, >>> >> > > >>> >> > > Any comments? >>> >> > > >>> >> > >>> >> > Apologies for the delay. I have been travelling and am behind on email. >>> >> > >>> >> > > Anyway we can modify the code if you insist on using an intermediate CPU IO >>> >> > > address space. >>> >> > > >>> >> > >>> >> > I have not made up my mind yet, to be honest. I agree there is a >>> >> > certain elegance to merging both translations, but I am concerned that >>> >> > existing EDK2 code may deal poorly with I/O addresses that require >>> >> > more than 32 bits to express. >>> >> > >>> >> > Did you try the mm command in the shell for instance? As you know, I >>> >> > recently removed an artificial address range limit there, but I wonder >>> >> > if it uses 64-bit variables for I/O ports.