From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.9198.1583315703082645765 for ; Wed, 04 Mar 2020 01:55:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=xyFJZf7v; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id r7so1586577wro.2 for ; Wed, 04 Mar 2020 01:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bxSmSXJhb058Pa26wbzUE8219mudGgPfagd0R/TkHkU=; b=xyFJZf7vaUlR98aLtsDg4k03GioXMvRk/nhOqcM3CaE3F4t7lEnnrNHkTorAYrTT5i yhA1H2yub4uSnYv33QFdyDsANlQ2At3l71taVyvXB0JIH1qFzTVUM23g2qtk3m7m5QGf aDxs6qbAtLANcy88W83nghuZqyPRyEWlLmQA/jvJWlQKZoA5jAX4JzLKPkoJwZmko7Pu BO4xGhtOxmbX9CVb0NyfoNN49KSeOwoLpNVePIsgnib8wcYXc+n+PiYftmq7DOKWCw56 dn4DrsMsT/KxInzULm7E7HDlvbiUD+kj+HVDvQAekWkV3ogF6by6i659s/2aCcgkeRwu GZrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bxSmSXJhb058Pa26wbzUE8219mudGgPfagd0R/TkHkU=; b=X961pcPU9oE39CcvOVcBSe7ZZMpO7hYN8Rmsszs5J2jciKjnUTJhbAYUnaKfooUluQ 1teQ9GBbvaftoywVdJeBv1v97eKzx4PJEFdxOTXtr75L5cVid/HNNYktg/xAKvmIqtJn EN7LkPVzVqt0kJ03veFS6iSLQkZQiBsr4ze2FI43FWs/jpUK3Ozxv/nnAAORr61vM3M6 fHoPjYJZYd9e3bKPDKdzD9apAq8fnOn5xkSG8PpdjpfqxizBEugychAgz6gQyXhhc4C/ ZyTzpylrE6mXy2cEpjaOohRxF1D1J7c5/Rb/rFEOJT7Dmk1M9Ip4Ch+ltzXyoizDSB3C EZnA== X-Gm-Message-State: ANhLgQ0D7+IDEj+2BnVJj0C7SpwF3ZNtLBhqrtsS4r+WdHOY0ANa1Mqv zfbV2GghJJ3K0wb1CyrP9PHToU+ekAmj/QbWi13vmw== X-Google-Smtp-Source: ADFU+vtdvzYrC7lyxKV+KrqBJR4IBgdsxQlp9JdyabbIMzPyjj0NVs4RPqnGNrTQPhWYR8MD9/YGPx5H/tzrD8rupqI= X-Received: by 2002:a05:6000:110b:: with SMTP id z11mr3377145wrw.252.1583315701617; Wed, 04 Mar 2020 01:55:01 -0800 (PST) MIME-Version: 1.0 References: <20200304094413.19462-1-lersek@redhat.com> In-Reply-To: <20200304094413.19462-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Wed, 4 Mar 2020 10:54:50 +0100 Message-ID: Subject: Re: [PATCH 0/2] OvmfPkg, ArmVirtPkg: sync Timeout with PcdPlatformBootTimeOut To: Laszlo Ersek Cc: edk2-devel-groups-io , Jordan Justen , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek wrote: > > Repo: https://pagure.io/lersek/edk2.git > Branch: timeout_var > > In the PlatformBootManagerLib instances, set the Timeout global variable > to the same value as PcdPlatformBootTimeOut. This way the "setvar" > command in the UEFI shell, and the "efibootmgr" command in a Linux > guest, can report the front page timeout that was requested on the QEMU > command line (see GetFrontPageTimeoutFromQemu() in > "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > > A DEBUG_VERBOSE message is logged on success too, for our QE team's > sake. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Philippe Mathieu-Daud=C3=A9 > > Thanks > Laszlo > > Laszlo Ersek (2): > OvmfPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > Provided that the use of the bare 'sizeof ' doesn't throw up any build errors with Clang (I seem to remember a report from Mike Kinney about this?) Reviewed-by: Ard Biesheuvel > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2= 7 ++++++++++++++++++-- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | = 1 + > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2= 6 +++++++++++++++++-- > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | = 2 ++ > 4 files changed, 52 insertions(+), 4 deletions(-) > > -- > 2.19.1.3.g30247aa5d201 >