public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE
Date: Thu, 20 Dec 2018 11:42:25 +0100	[thread overview]
Message-ID: <CAKv+Gu8UT=ks4BRjRjmAxU_ZumXU+1QChe0xNvhro=6_qH6Heg@mail.gmail.com> (raw)
In-Reply-To: <CAFA6WYPtFA3Xs=j6cdDSwMMeHmO==sHfvT8cukw0CTY1CNgkVA@mail.gmail.com>

On Thu, 20 Dec 2018 at 06:34, Sumit Garg <sumit.garg@linaro.org> wrote:
>
> On Wed, 19 Dec 2018 at 20:37, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >
> > On Tue, 18 Dec 2018 at 14:05, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Tue, 18 Dec 2018 at 14:04, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > >
> > > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > >
> > > > > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > > > >
> > > > > > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > > > >
> > > > > > > > Include a prebuilt binary of OP-TEE OS built from commit
> > > > > > > >     a5d528c7e54fd7726230483bd4cd5c4786d7703f.
> > > > > > > >     (https://github.com/OP-TEE/optee_os.git master)
> > > > > > > >
> > > > > > > > Also update ARM-TF RELEASE build to commit 47577cbaaf4b.
> > > > > > > >
> > > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > > > > > > ---
> > > > > > > >  Platform/Socionext/DeveloperBox/fip_all_arm_tf.bin | Bin 46824 -> 415251 bytes
> > > > > > >
> > > > > > > Thanks Sumit!
> > > > > > >
> > > > > > > In the future, please use --no-binary when sending patches like this one.
> > > > > > >
> > > > > >
> > > > > > Sure will take care of this in future.
> > > > > >
> > > > > > > However, do you have any explanation why the size increases 10x? This
> > > > > > > patch adds the pseudo-TA, but OP-TEE was already included in the
> > > > > > > previous build, so this is a bit unexpected.
> > > > > > >
> > > > > >
> > > > > > Actually I think ARM-TF was not updated earlier to include OP-TEE in
> > > > > > upstream (tee.bin size: 316392 bytes).
> > > > > >
> > > > >
> > > > > Ah, right. So we added the OP-TEE aware ATF build but not OP-TEE
> > > > > itself? That would indeed explain it.
> > > >
> > > > We didn't updated ATF build at all in upstream. I think you have
> > > > updated ATF build in local repo [1] only.
> > > >
> > > > [1] git://git.linaro.org/leg/noupstream/edk2-non-osi.git
> > > >
> > >
> > > Indeed.
> >
> > I cannot apply this patch. Could you please rebase it to latest
> > upstream edk2-non-osi and send me a link to the repo?
>
> Here is the link [1] to upstream repo with this patch applied.
>
> [1] ssh://git@git.linaro.org/people/sumit.garg/edk2-non-osi.git
>

Thanks Sumit.

I triggered a new capsule build with this image (#48)

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as  047bb77dd938..1e2ca640be54


      reply	other threads:[~2018-12-20 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 12:09 [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE Sumit Garg
2018-12-18 12:45 ` Ard Biesheuvel
2018-12-18 12:58   ` Sumit Garg
2018-12-18 12:59     ` Ard Biesheuvel
2018-12-18 13:04       ` Sumit Garg
2018-12-18 13:05         ` Ard Biesheuvel
2018-12-19 15:07           ` Ard Biesheuvel
2018-12-20  5:34             ` Sumit Garg
2018-12-20 10:42               ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu8UT=ks4BRjRjmAxU_ZumXU+1QChe0xNvhro=6_qH6Heg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox