Re: [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Thu, 20 Dec 2018 at 06:34, Sumit Garg <sumit.garg@linaro.org> wrote:
>
> On Wed, 19 Dec 2018 at 20:37, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >
> > On Tue, 18 Dec 2018 at 14:05, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Tue, 18 Dec 2018 at 14:04, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > >
> > > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > >
> > > > > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > > > >
> > > > > > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > > > >
> > > > > > > > Include a prebuilt binary of OP-TEE OS built from commit
> > > > > > > >     a5d528c7e54fd7726230483bd4cd5c4786d7703f.
> > > > > > > >     (https://github.com/OP-TEE/optee_os.git master)
> > > > > > > >
> > > > > > > > Also update ARM-TF RELEASE build to commit 47577cbaaf4b.
> > > > > > > >
> > > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > > > > > > ---
> > > > > > > >  Platform/Socionext/DeveloperBox/fip_all_arm_tf.bin | Bin 46824 -> 415251 bytes
> > > > > > >
> > > > > > > Thanks Sumit!
> > > > > > >
> > > > > > > In the future, please use --no-binary when sending patches like this one.
> > > > > > >
> > > > > >
> > > > > > Sure will take care of this in future.
> > > > > >
> > > > > > > However, do you have any explanation why the size increases 10x? This
> > > > > > > patch adds the pseudo-TA, but OP-TEE was already included in the
> > > > > > > previous build, so this is a bit unexpected.
> > > > > > >
> > > > > >
> > > > > > Actually I think ARM-TF was not updated earlier to include OP-TEE in
> > > > > > upstream (tee.bin size: 316392 bytes).
> > > > > >
> > > > >
> > > > > Ah, right. So we added the OP-TEE aware ATF build but not OP-TEE
> > > > > itself? That would indeed explain it.
> > > >
> > > > We didn't updated ATF build at all in upstream. I think you have
> > > > updated ATF build in local repo [1] only.
> > > >
> > > > [1] git://git.linaro.org/leg/noupstream/edk2-non-osi.git
> > > >
> > >
> > > Indeed.
> >
> > I cannot apply this patch. Could you please rebase it to latest
> > upstream edk2-non-osi and send me a link to the repo?
>
> Here is the link [1] to upstream repo with this patch applied.
>
> [1] ssh://git@git.linaro.org/people/sumit.garg/edk2-non-osi.git
>

Thanks Sumit.

I triggered a new capsule build with this image (#48)

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as  047bb77dd938..1e2ca640be54