From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::242; helo=mail-oi1-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E2D0C211A4583 for ; Thu, 20 Dec 2018 02:42:37 -0800 (PST) Received: by mail-oi1-x242.google.com with SMTP id x23so1146287oix.3 for ; Thu, 20 Dec 2018 02:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h5VtLV1Rk6+vnD0hc18BoC06pp8vfINdrKO8vFZxSks=; b=UlbiXP9N/naA09W8jc0zDHSZTOTlzT8L59kOkCvVbyH0eaEdWBflNVrHaQhz2ifBkr LHJF0p2nV3PxKwfJASPZuIPy8krgeVQGosviOqXST7Niy4mcY9mJto7ZavRK8Hx9W1wR xP7RPwVRADefEV7AK+pFiooRP0mbQhnglnmGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h5VtLV1Rk6+vnD0hc18BoC06pp8vfINdrKO8vFZxSks=; b=KwNVgBjuusZqj3XIzixhgqXVmIMabEXFoMqgKuGIFh5u7H98Gi+Q/Nk6VLSf/H46ze DAjdRH4T6W7+XwTpbyj3ecQVGVjX+UppebsVYSwKNUJnHKEBKReroqbMpam4VkECjZ/e +3C3w+3wVHU7nUXz961Xar3e49RTRZD4IXEjPrgfxUOWqQWf92or0p2Wh9XvN3Co5fvX aoiVJ+H/gV6913KohbLjIeZYMXtr4MRDi/TtyiQCJsLVbPv97N/2GT3LVpoBvE1eA3Tn sYRkMv0WsqBbseAijzcEXZVdh1qjXBnUWmmgDSjxzkNv9TsPaBXIntL9rKLYYLidcmjG hUUw== X-Gm-Message-State: AA+aEWZ6ztKnq1cjkdZR/G2Es7K1aY+aAlXOAe1h1HZWR9F0Y6yeOvCo LCYvCgKX9HRNOYYAVG8IeG+2ZSHdVzLhgWdQAacNuA== X-Google-Smtp-Source: AFSGD/XnBvK65H4Lfgnnt0PMAdl/W5E+KPn243gYqw+MXqyXYsUmPKf+ux3FHkMn9UuF3a+2ZORRnpiKl/lBOM2eB/c= X-Received: by 2002:aca:b642:: with SMTP id g63mr1514828oif.195.1545302557074; Thu, 20 Dec 2018 02:42:37 -0800 (PST) MIME-Version: 1.0 References: <1545134943-16346-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 20 Dec 2018 11:42:25 +0100 Message-ID: To: Sumit Garg Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Leif Lindholm Subject: Re: [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 10:42:38 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 20 Dec 2018 at 06:34, Sumit Garg wrote: > > On Wed, 19 Dec 2018 at 20:37, Ard Biesheuvel wrote: > > > > On Tue, 18 Dec 2018 at 14:05, Ard Biesheuvel wrote: > > > > > > On Tue, 18 Dec 2018 at 14:04, Sumit Garg wrote: > > > > > > > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel wrote: > > > > > > > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote: > > > > > > > > > > > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel wrote: > > > > > > > > > > > > > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote: > > > > > > > > > > > > > > > > Include a prebuilt binary of OP-TEE OS built from commit > > > > > > > > a5d528c7e54fd7726230483bd4cd5c4786d7703f. > > > > > > > > (https://github.com/OP-TEE/optee_os.git master) > > > > > > > > > > > > > > > > Also update ARM-TF RELEASE build to commit 47577cbaaf4b. > > > > > > > > > > > > > > > > Cc: Ard Biesheuvel > > > > > > > > Cc: Leif Lindholm > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > > Signed-off-by: Sumit Garg > > > > > > > > --- > > > > > > > > Platform/Socionext/DeveloperBox/fip_all_arm_tf.bin | Bin 46824 -> 415251 bytes > > > > > > > > > > > > > > Thanks Sumit! > > > > > > > > > > > > > > In the future, please use --no-binary when sending patches like this one. > > > > > > > > > > > > > > > > > > > Sure will take care of this in future. > > > > > > > > > > > > > However, do you have any explanation why the size increases 10x? This > > > > > > > patch adds the pseudo-TA, but OP-TEE was already included in the > > > > > > > previous build, so this is a bit unexpected. > > > > > > > > > > > > > > > > > > > Actually I think ARM-TF was not updated earlier to include OP-TEE in > > > > > > upstream (tee.bin size: 316392 bytes). > > > > > > > > > > > > > > > > Ah, right. So we added the OP-TEE aware ATF build but not OP-TEE > > > > > itself? That would indeed explain it. > > > > > > > > We didn't updated ATF build at all in upstream. I think you have > > > > updated ATF build in local repo [1] only. > > > > > > > > [1] git://git.linaro.org/leg/noupstream/edk2-non-osi.git > > > > > > > > > > Indeed. > > > > I cannot apply this patch. Could you please rebase it to latest > > upstream edk2-non-osi and send me a link to the repo? > > Here is the link [1] to upstream repo with this patch applied. > > [1] ssh://git@git.linaro.org/people/sumit.garg/edk2-non-osi.git > Thanks Sumit. I triggered a new capsule build with this image (#48) Reviewed-by: Ard Biesheuvel Pushed as 047bb77dd938..1e2ca640be54