From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E8CB6222630A9 for ; Thu, 22 Feb 2018 08:27:07 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id p78so6591998iod.13 for ; Thu, 22 Feb 2018 08:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8dwHUIAXfmITaENQU+5NdPDwmhQ3qWT4vkxjJZCB1vE=; b=j8tMmmwdJ3w3hE65HvzSm6Y+ogsmhIyJYdzH+aF7MpWdXEAObyz3MPQWAbEkY40iE6 /P/MUBBbiyxEoxuC6P9aNv2LpiyhqDVrCxBqFhsAMcLR6EaWaaNmncinIFnQ6FipFVr2 dZmvTEpDFKHFQZHUebrauriGzVYjCrvyhYO8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8dwHUIAXfmITaENQU+5NdPDwmhQ3qWT4vkxjJZCB1vE=; b=JBloFRZvDfnZBmNDXBeDPzOjsHFFfls9RNt9hpU6rUYskkaXiKxJhTd3pa9teP+5QT dExE5MCMlZk084b/YCctKN7LC6susmLVoSeGm7b5VirIvSUQ8+zmLSOzWtftJxKMjnr3 yRaSadNLk8sXQwcg5gB0H5ucrF3Wjeb8gr5TpReAUK1A+K837wD/fuAP/L0HwJn3VZwm m7RcW4HlzpKDbKsWJALzWnqSEH5Qa8NdrqOKUX+AOMTIwKMg8UeWGZcbbPIb8kVAsFGO kviNd2vEd193U3cIR/JW24w5hENKgPF8mIVAaJtAgHSW0nhKsA14dijiMnw6VDtzm3XW jN2Q== X-Gm-Message-State: APf1xPDkoIWUOBQaIZTgPvH9Blv+BYLoT+EpoFGV7GHNsX9VRrD0KABo +FIrb3HpGlzQKhrgRLAQfbHdPoQASpD0mYlYduUC7Q== X-Google-Smtp-Source: AG47ELvuqAJrpcyBHemvIvwjhtoqp//2F3a6pvmaRlN1KysUe40Qw6zj69beS2dzT6WmBrntlOS5oPCHMZga08eSXG0= X-Received: by 10.107.41.16 with SMTP id p16mr9534059iop.173.1519317187920; Thu, 22 Feb 2018 08:33:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Thu, 22 Feb 2018 08:33:07 -0800 (PST) In-Reply-To: <20171215165925.12306-4-leif.lindholm@linaro.org> References: <20171215165925.12306-1-leif.lindholm@linaro.org> <20171215165925.12306-4-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 22 Feb 2018 16:33:07 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH v2 3/3] EmbeddedPkg: use central variable definitions in .vfr files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:27:08 -0000 Content-Type: text/plain; charset="UTF-8" On 15 December 2017 at 16:59, Leif Lindholm wrote: > Use UefiMultiPhase.h in Vfr.vfr instead of duplicating EFI_VARIABLE_* > definitions. > > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr | 9 +-------- > EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr | 9 +-------- > 2 files changed, 2 insertions(+), 16 deletions(-) > > diff --git a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr > index a1e603abf0..725fbf52a5 100644 > --- a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr > +++ b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr > @@ -12,16 +12,9 @@ > * > **/ > > +#include > #include "ConsolePrefDxe.h" > > -// > -// EFI Variable attributes > -// > -#define EFI_VARIABLE_NON_VOLATILE 0x00000001 > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002 > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004 > -#define EFI_VARIABLE_READ_ONLY 0x00000008 > - > formset > guid = CONSOLE_PREF_FORMSET_GUID, > title = STRING_TOKEN(STR_FORM_SET_TITLE), > diff --git a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr > index 3516746c4d..80c6f36425 100644 > --- a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr > +++ b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr > @@ -12,16 +12,9 @@ > * > **/ > > +#include > #include "DtPlatformDxe.h" > > -// > -// EFI Variable attributes > -// > -#define EFI_VARIABLE_NON_VOLATILE 0x00000001 > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002 > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004 > -#define EFI_VARIABLE_READ_ONLY 0x00000008 > - > formset > guid = DT_PLATFORM_FORMSET_GUID, > title = STRING_TOKEN(STR_FORM_SET_TITLE), > -- > 2.11.0 >