public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Nadav Haklai" <nadavh@marvell.com>,
	"Jan Dąbroś" <jsd@semihalf.com>,
	"Grzegorz Jaszczyk" <jaz@semihalf.com>,
	"Kostya Porotchkin" <kostap@marvell.com>,
	"Tomasz Michalec" <tm@semihalf.com>
Subject: Re: [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information
Date: Mon, 12 Nov 2018 11:24:58 +0100	[thread overview]
Message-ID: <CAKv+Gu8UcfM4NjtdUf+_n=jx3r-fDsfqrTwtcVwB5z_cFzhp4w@mail.gmail.com> (raw)
In-Reply-To: <1541804508-27499-3-git-send-email-mw@semihalf.com>

On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas <mw@semihalf.com> wrote:
>
> From: Tomasz Michalec <tm@semihalf.com>
>
> Added fields specific for Xenon host controller and declaration
> of ArmadaBoardDescSdMmcGet function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 22 +++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> index ee8e06e..8e29a68 100644
> --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> @@ -55,9 +55,21 @@ typedef struct {
>  //
>  // SDMMC devices per-board description
>  //
> +typedef enum {
> +  RemovableSlot,
> +  EmbeddedSlot,
> +  SharedBusSlot,
> +  UnknownSlot
> +} MV_SDMMC_SLOT_TYPE;
> +
>  typedef struct {
>    MV_SOC_SDMMC_DESC *SoC;
> -  UINTN              SdMmcDevCount;
> +  UINTN    SdMmcDevCount;
> +  BOOLEAN  Xenon1v8Enabled;
> +  BOOLEAN  Xenon8BitBusEnabled;
> +  BOOLEAN  XenonSlowModeEnabled;
> +  UINT8    XenonTuningStepDivisor;
> +  MV_SDMMC_SLOT_TYPE SlotType;
>  } MV_BOARD_SDMMC_DESC;
>
>  //
> @@ -84,4 +96,12 @@ typedef struct {
>    UINTN             UtmiDevCount;
>    UINTN             UtmiPortType;
>  } MV_BOARD_UTMI_DESC;
> +
> +EFI_STATUS
> +EFIAPI
> +ArmadaBoardDescSdMmcGet (
> +  IN OUT UINTN               *SdMmcDevCount,
> +  IN OUT MV_BOARD_SDMMC_DESC **SdMmcDesc
> +  );
> +
>  #endif /* __ARMADA_SOC_DESC_LIB_H__ */
> --
> 2.7.4
>


  reply	other threads:[~2018-11-12 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 23:01 [platforms: PATCH v4 0/7] Armada7k8k Xenon driver rework Marcin Wojtas
2018-11-09 23:01 ` [platforms: PATCH v4 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride Marcin Wojtas
2018-11-12 10:24   ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information Marcin Wojtas
2018-11-12 10:24   ` Ard Biesheuvel [this message]
2018-11-09 23:01 ` [platforms: PATCH v4 3/7] SolidRun/Armada80x0McBin: Introduce board description library Marcin Wojtas
2018-11-12 10:26   ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 5/7] Marvell/Armada80x0Db: " Marcin Wojtas
2018-11-12 10:28   ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc Marcin Wojtas
2018-11-12 10:29   ` Ard Biesheuvel
2018-11-09 23:01 ` [platforms: PATCH v4 7/7] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe Marcin Wojtas
2018-11-12 10:36   ` Ard Biesheuvel
     [not found] ` <1541804508-27499-5-git-send-email-mw@semihalf.com>
2018-11-12 10:27   ` [platforms: PATCH v4 4/7] Marvell/Armada70x0Db: Introduce board description library Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu8UcfM4NjtdUf+_n=jx3r-fDsfqrTwtcVwB5z_cFzhp4w@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox