From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: Daniil Egranov <daniil.egranov@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 0/4] SataSiI3132Dxe fixes
Date: Fri, 27 Oct 2017 18:00:30 +0100 [thread overview]
Message-ID: <CAKv+Gu8Ug44rt5MYLSeeM+1Q-6PjXz4aHD_GzNSdHvDzL7c1OQ@mail.gmail.com> (raw)
In-Reply-To: <658a30f2-d5f0-6022-988c-1071290bc76d@arm.com>
On 27 October 2017 at 17:57, Jeremy Linton <jeremy.linton@arm.com> wrote:
> Hi,
>
> On 10/27/2017 12:33 AM, Daniil Egranov wrote:
>>
>> This set of patches fixes an issue with 64-bit DMA and implements
>> the missing exit boot event and driver stop functionality including
>> memory/protocols cleanup procedure.
>>
>> Daniil Egranov (4):
>> Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations
>> Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer
>> Drivers/SataSiI3132Dxe: Enable multi-controller support
>> Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures
>>
>> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 301
>> ++++++++++++++++-----
>> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 17 ++
>> .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 4 +-
>> 3 files changed, 252 insertions(+), 70 deletions(-)
>
>
> This is generally good, but there remain quite a number of "errors" in the
> command submission path as well as the completely unnecessary 4k IO
> alignment requirement which has been known to break older grubs/etc. A few
> of those "errors" were fixed in this patch set (1) as well, so might be
> worthwhile if you are looking at this driver to integrate those fixes as
> well.
>
Yes, please. And apologies for forgetting about thise patches.
> (1) https://lists.01.org/pipermail/edk2-devel/2017-March/008277.html
>
> Thanks,
prev parent reply other threads:[~2017-10-27 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 5:33 [PATCH 0/4] SataSiI3132Dxe fixes Daniil Egranov
2017-10-27 5:33 ` [PATCH 1/4] Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations Daniil Egranov
2017-10-27 9:22 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 2/4] Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer Daniil Egranov
2017-10-27 9:23 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 3/4] Drivers/SataSiI3132Dxe: Enable multi-controller support Daniil Egranov
2017-10-27 12:42 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 4/4] Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures Daniil Egranov
2017-10-27 12:47 ` Ard Biesheuvel
2017-10-27 12:48 ` [PATCH 0/4] SataSiI3132Dxe fixes Ard Biesheuvel
2017-10-27 16:57 ` Jeremy Linton
2017-10-27 17:00 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8Ug44rt5MYLSeeM+1Q-6PjXz4aHD_GzNSdHvDzL7c1OQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox