From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4EEA521F3B3F5 for ; Fri, 27 Oct 2017 09:56:43 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id j17so14057961iod.5 for ; Fri, 27 Oct 2017 10:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=S69eaYvg9ic7bjncb6yM5znAwFn+i0baPQCoWXbpezk=; b=STswTmp9oKpDDUii5wkwiNKb0kX42Ei+MZ/c/Db3BVAAzGoQvKcJDLVhk2Y/W3x9qS ojxNHEu7O1PzIwV6OLp13NZ8sRpbXbJK9czzS93q1Hf8QCpsNPjVeVjVPyw0IsS2Onxi YV/mw9hbhJGTO4zZrrKUO1BiUM9qCtOY95MTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=S69eaYvg9ic7bjncb6yM5znAwFn+i0baPQCoWXbpezk=; b=ZRpGEFgy+634u6WqMaYj4ApMQCv2ZsHeAIOb3bUmZCzyXrVPlk6CWZ8MZKPXJ1HJkX z5sCMINtCGN3LwD4sqAnsZIyI5IXd+E5ovPKKbBkmha4qCgBn/18NRSqXBCGgFQthxkU SrIzaA/WlIqxwQz3bBWvgBCtY4vWO9RhZTG/MGvlknRYV6JlCADKUsxKW3/yyho7sCEj +Z/fTIy8VHxUFFpa3W208bujzgYr9XEaYeebh8MwiSFedyqhXDPF0IvaPpxjOYzTZi1z v8OuYCMsHRMmMsMbvSkDwAa70R2W14ws53c6zI+iCFNXM7O8ryio8jgSbotqMMp9gUbe xRhQ== X-Gm-Message-State: AMCzsaVo2MSqT0K3jofSlxYzHcsZ07CEx37NNM8T8fUQsSsiAjJGfs2p 7RC8nPu6ixmUi3fdNtmp1VdcTZcUS+5Kc5oEhXftLA== X-Google-Smtp-Source: ABhQp+TRMYXSbKt6WVV7Sm3HWS2U3xba84I5fEo9Iphpmag/P05Nt87qw5ikV8NVtCQp2OQIeo7KNEvezFZird09QZI= X-Received: by 10.107.82.6 with SMTP id g6mr1428439iob.253.1509123630698; Fri, 27 Oct 2017 10:00:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Fri, 27 Oct 2017 10:00:30 -0700 (PDT) In-Reply-To: <658a30f2-d5f0-6022-988c-1071290bc76d@arm.com> References: <20171027053326.48815-1-daniil.egranov@arm.com> <658a30f2-d5f0-6022-988c-1071290bc76d@arm.com> From: Ard Biesheuvel Date: Fri, 27 Oct 2017 18:00:30 +0100 Message-ID: To: Jeremy Linton Cc: Daniil Egranov , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 0/4] SataSiI3132Dxe fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 16:56:44 -0000 Content-Type: text/plain; charset="UTF-8" On 27 October 2017 at 17:57, Jeremy Linton wrote: > Hi, > > On 10/27/2017 12:33 AM, Daniil Egranov wrote: >> >> This set of patches fixes an issue with 64-bit DMA and implements >> the missing exit boot event and driver stop functionality including >> memory/protocols cleanup procedure. >> >> Daniil Egranov (4): >> Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations >> Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer >> Drivers/SataSiI3132Dxe: Enable multi-controller support >> Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures >> >> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 301 >> ++++++++++++++++----- >> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 17 ++ >> .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 4 +- >> 3 files changed, 252 insertions(+), 70 deletions(-) > > > This is generally good, but there remain quite a number of "errors" in the > command submission path as well as the completely unnecessary 4k IO > alignment requirement which has been known to break older grubs/etc. A few > of those "errors" were fixed in this patch set (1) as well, so might be > worthwhile if you are looking at this driver to integrate those fixes as > well. > Yes, please. And apologies for forgetting about thise patches. > (1) https://lists.01.org/pipermail/edk2-devel/2017-March/008277.html > > Thanks,