From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Daniil Egranov <daniil.egranov@arm.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 0/4] SataSiI3132Dxe fixes
Date: Fri, 27 Oct 2017 13:48:59 +0100 [thread overview]
Message-ID: <CAKv+Gu8VnVgc_+2Dr9R+i_wcDkgAEXE+q+-LKAKfV2XCDbDfDQ@mail.gmail.com> (raw)
In-Reply-To: <20171027053326.48815-1-daniil.egranov@arm.com>
On 27 October 2017 at 06:33, Daniil Egranov <daniil.egranov@arm.com> wrote:
> This set of patches fixes an issue with 64-bit DMA and implements
> the missing exit boot event and driver stop functionality including
> memory/protocols cleanup procedure.
>
> Daniil Egranov (4):
> Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations
> Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer
> Drivers/SataSiI3132Dxe: Enable multi-controller support
> Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures
>
> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 301 ++++++++++++++++-----
> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 17 ++
> .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 4 +-
> 3 files changed, 252 insertions(+), 70 deletions(-)
>
Hi Daniil,
Thanks for taking the time to fix this driver.
I will go ahead and push the first two patches, given that they are
self-contained and obvious bug fixes.
The remaining patches, please split them up, and please align more
closely with what other upstream PCI drivers do.
Regards,
Ard.
next prev parent reply other threads:[~2017-10-27 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 5:33 [PATCH 0/4] SataSiI3132Dxe fixes Daniil Egranov
2017-10-27 5:33 ` [PATCH 1/4] Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations Daniil Egranov
2017-10-27 9:22 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 2/4] Drivers/SataSiI3132Dxe: Allow 64-bit DMA transfer Daniil Egranov
2017-10-27 9:23 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 3/4] Drivers/SataSiI3132Dxe: Enable multi-controller support Daniil Egranov
2017-10-27 12:42 ` Ard Biesheuvel
2017-10-27 5:33 ` [PATCH 4/4] Drivers/SataSiI3132Dxe: Fixed startup and shutdown procedures Daniil Egranov
2017-10-27 12:47 ` Ard Biesheuvel
2017-10-27 12:48 ` Ard Biesheuvel [this message]
2017-10-27 16:57 ` [PATCH 0/4] SataSiI3132Dxe fixes Jeremy Linton
2017-10-27 17:00 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8VnVgc_+2Dr9R+i_wcDkgAEXE+q+-LKAKfV2XCDbDfDQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox