* [PATCH] ArmPkg/ArmMmuLib: Add new attribute
@ 2017-11-07 12:56 Heyi Guo
2017-11-07 12:56 ` [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE Heyi Guo
0 siblings, 1 reply; 6+ messages in thread
From: Heyi Guo @ 2017-11-07 12:56 UTC (permalink / raw)
To: linaro-uefi, edk2-devel; +Cc: leif.lindholm, ard.biesheuvel, Heyi Guo
V1 changes upon RFC version:
1. Rename NONSHARE to NONSHAREABLE per review comments.
2. Place these two uncommon attributes after normal WRITE_BACK attributes to imply they should not be used by default.
3. Add warnning comments.
Peicong Li (1):
ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
ArmPkg/Include/Library/ArmLib.h | 7 +++++++
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
2 files changed, 11 insertions(+)
--
2.7.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
2017-11-07 12:56 [PATCH] ArmPkg/ArmMmuLib: Add new attribute Heyi Guo
@ 2017-11-07 12:56 ` Heyi Guo
2017-11-07 13:22 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Heyi Guo @ 2017-11-07 12:56 UTC (permalink / raw)
To: linaro-uefi, edk2-devel
Cc: leif.lindholm, ard.biesheuvel, Peicong Li, Heyi Guo
From: Peicong Li <lipeicong@huawei.com>
Flash region needs to be set as cacheable (write back) to increase
performance, if PEI is still XIP on flash or DXE FV is decompressed
from flash FV. However some ARM platforms do not support to set flash
as inner shareable since flash is not normal DDR memory and it will
not respond to cache snoop request, which will causes system hang
after MMU is enabled.
So we need a new ARM memory region attribute WRITE_BACK_NONSHAREABLE
for flash region on these platforms specifically. This attribute will
set the region as write back but not inner shared.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Peicong Li <lipeicong@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/Include/Library/ArmLib.h | 7 +++++++
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
index 24ffe9f..38199be 100644
--- a/ArmPkg/Include/Library/ArmLib.h
+++ b/ArmPkg/Include/Library/ArmLib.h
@@ -41,6 +41,13 @@ typedef enum {
ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_UNCACHED_UNBUFFERED,
ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK,
ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK,
+ // On some platforms, memory mapped flash region is designed as not supporting
+ // shareable attribute, so WRITE_BACK_NONSHAREABLE is added for such special
+ // need.
+ // Do NOT use below two attributes if you are not sure.
+ ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE,
+ ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE,
+
ARM_MEMORY_REGION_ATTRIBUTE_WRITE_THROUGH,
ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_THROUGH,
ARM_MEMORY_REGION_ATTRIBUTE_DEVICE,
diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
index 8bd1c6f..4b62ecb 100644
--- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
+++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
@@ -35,6 +35,10 @@ ArmMemoryAttributeToPageAttribute (
)
{
switch (Attributes) {
+ case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE:
+ case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE:
+ return TT_ATTR_INDX_MEMORY_WRITE_BACK;
+
case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK:
case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK:
return TT_ATTR_INDX_MEMORY_WRITE_BACK | TT_SH_INNER_SHAREABLE;
--
2.7.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
2017-11-07 12:56 ` [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE Heyi Guo
@ 2017-11-07 13:22 ` Ard Biesheuvel
2017-11-07 13:29 ` Leif Lindholm
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2017-11-07 13:22 UTC (permalink / raw)
To: Heyi Guo; +Cc: linaro-uefi, edk2-devel@lists.01.org, Leif Lindholm, Peicong Li
On 7 November 2017 at 12:56, Heyi Guo <heyi.guo@linaro.org> wrote:
> From: Peicong Li <lipeicong@huawei.com>
>
> Flash region needs to be set as cacheable (write back) to increase
> performance, if PEI is still XIP on flash or DXE FV is decompressed
> from flash FV. However some ARM platforms do not support to set flash
> as inner shareable since flash is not normal DDR memory and it will
> not respond to cache snoop request, which will causes system hang
> after MMU is enabled.
>
> So we need a new ARM memory region attribute WRITE_BACK_NONSHAREABLE
> for flash region on these platforms specifically. This attribute will
> set the region as write back but not inner shared.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Peicong Li <lipeicong@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/Include/Library/ArmLib.h | 7 +++++++
> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
> index 24ffe9f..38199be 100644
> --- a/ArmPkg/Include/Library/ArmLib.h
> +++ b/ArmPkg/Include/Library/ArmLib.h
> @@ -41,6 +41,13 @@ typedef enum {
> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_UNCACHED_UNBUFFERED,
> ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK,
> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK,
> + // On some platforms, memory mapped flash region is designed as not supporting
> + // shareable attribute, so WRITE_BACK_NONSHAREABLE is added for such special
> + // need.
> + // Do NOT use below two attributes if you are not sure.
> + ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE,
> + ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE,
> +
> ARM_MEMORY_REGION_ATTRIBUTE_WRITE_THROUGH,
> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_THROUGH,
> ARM_MEMORY_REGION_ATTRIBUTE_DEVICE,
> diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> index 8bd1c6f..4b62ecb 100644
> --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> @@ -35,6 +35,10 @@ ArmMemoryAttributeToPageAttribute (
> )
> {
> switch (Attributes) {
> + case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE:
> + case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE:
> + return TT_ATTR_INDX_MEMORY_WRITE_BACK;
> +
> case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK:
> case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK:
> return TT_ATTR_INDX_MEMORY_WRITE_BACK | TT_SH_INNER_SHAREABLE;
> --
> 2.7.2.windows.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
2017-11-07 13:22 ` Ard Biesheuvel
@ 2017-11-07 13:29 ` Leif Lindholm
2017-11-07 13:30 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Leif Lindholm @ 2017-11-07 13:29 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Heyi Guo, linaro-uefi, edk2-devel@lists.01.org, Peicong Li
On Tue, Nov 07, 2017 at 01:22:19PM +0000, Ard Biesheuvel wrote:
> On 7 November 2017 at 12:56, Heyi Guo <heyi.guo@linaro.org> wrote:
> > From: Peicong Li <lipeicong@huawei.com>
> >
> > Flash region needs to be set as cacheable (write back) to increase
> > performance, if PEI is still XIP on flash or DXE FV is decompressed
> > from flash FV. However some ARM platforms do not support to set flash
> > as inner shareable since flash is not normal DDR memory and it will
> > not respond to cache snoop request, which will causes system hang
> > after MMU is enabled.
> >
> > So we need a new ARM memory region attribute WRITE_BACK_NONSHAREABLE
> > for flash region on these platforms specifically. This attribute will
> > set the region as write back but not inner shared.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Peicong Li <lipeicong@huawei.com>
> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > ArmPkg/Include/Library/ArmLib.h | 7 +++++++
> > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
> > 2 files changed, 11 insertions(+)
> >
> > diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
> > index 24ffe9f..38199be 100644
> > --- a/ArmPkg/Include/Library/ArmLib.h
> > +++ b/ArmPkg/Include/Library/ArmLib.h
> > @@ -41,6 +41,13 @@ typedef enum {
> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_UNCACHED_UNBUFFERED,
> > ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK,
> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK,
> > + // On some platforms, memory mapped flash region is designed as not supporting
> > + // shareable attribute, so WRITE_BACK_NONSHAREABLE is added for such special
> > + // need.
> > + // Do NOT use below two attributes if you are not sure.
> > + ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE,
> > + ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE,
> > +
> > ARM_MEMORY_REGION_ATTRIBUTE_WRITE_THROUGH,
> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_THROUGH,
> > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE,
> > diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> > index 8bd1c6f..4b62ecb 100644
> > --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> > +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
> > @@ -35,6 +35,10 @@ ArmMemoryAttributeToPageAttribute (
> > )
> > {
> > switch (Attributes) {
> > + case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE:
> > + case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE:
> > + return TT_ATTR_INDX_MEMORY_WRITE_BACK;
> > +
> > case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK:
> > case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK:
> > return TT_ATTR_INDX_MEMORY_WRITE_BACK | TT_SH_INNER_SHAREABLE;
> > --
> > 2.7.2.windows.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
2017-11-07 13:29 ` Leif Lindholm
@ 2017-11-07 13:30 ` Ard Biesheuvel
2017-11-08 1:56 ` Heyi Guo
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2017-11-07 13:30 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Heyi Guo, linaro-uefi, edk2-devel@lists.01.org, Peicong Li
On 7 November 2017 at 13:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Nov 07, 2017 at 01:22:19PM +0000, Ard Biesheuvel wrote:
>> On 7 November 2017 at 12:56, Heyi Guo <heyi.guo@linaro.org> wrote:
>> > From: Peicong Li <lipeicong@huawei.com>
>> >
>> > Flash region needs to be set as cacheable (write back) to increase
>> > performance, if PEI is still XIP on flash or DXE FV is decompressed
>> > from flash FV. However some ARM platforms do not support to set flash
>> > as inner shareable since flash is not normal DDR memory and it will
>> > not respond to cache snoop request, which will causes system hang
>> > after MMU is enabled.
>> >
>> > So we need a new ARM memory region attribute WRITE_BACK_NONSHAREABLE
>> > for flash region on these platforms specifically. This attribute will
>> > set the region as write back but not inner shared.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Peicong Li <lipeicong@huawei.com>
>> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed as 829633e3a82d. Thanks!
>> > ---
>> > ArmPkg/Include/Library/ArmLib.h | 7 +++++++
>> > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
>> > 2 files changed, 11 insertions(+)
>> >
>> > diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
>> > index 24ffe9f..38199be 100644
>> > --- a/ArmPkg/Include/Library/ArmLib.h
>> > +++ b/ArmPkg/Include/Library/ArmLib.h
>> > @@ -41,6 +41,13 @@ typedef enum {
>> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_UNCACHED_UNBUFFERED,
>> > ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK,
>> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK,
>> > + // On some platforms, memory mapped flash region is designed as not supporting
>> > + // shareable attribute, so WRITE_BACK_NONSHAREABLE is added for such special
>> > + // need.
>> > + // Do NOT use below two attributes if you are not sure.
>> > + ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE,
>> > + ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE,
>> > +
>> > ARM_MEMORY_REGION_ATTRIBUTE_WRITE_THROUGH,
>> > ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_THROUGH,
>> > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE,
>> > diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>> > index 8bd1c6f..4b62ecb 100644
>> > --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>> > +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>> > @@ -35,6 +35,10 @@ ArmMemoryAttributeToPageAttribute (
>> > )
>> > {
>> > switch (Attributes) {
>> > + case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE:
>> > + case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE:
>> > + return TT_ATTR_INDX_MEMORY_WRITE_BACK;
>> > +
>> > case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK:
>> > case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK:
>> > return TT_ATTR_INDX_MEMORY_WRITE_BACK | TT_SH_INNER_SHAREABLE;
>> > --
>> > 2.7.2.windows.1
>> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE
2017-11-07 13:30 ` Ard Biesheuvel
@ 2017-11-08 1:56 ` Heyi Guo
0 siblings, 0 replies; 6+ messages in thread
From: Heyi Guo @ 2017-11-08 1:56 UTC (permalink / raw)
To: Ard Biesheuvel, Leif Lindholm
Cc: linaro-uefi, edk2-devel@lists.01.org, Peicong Li
Thanks,
Heyi
在 11/7/2017 9:30 PM, Ard Biesheuvel 写道:
> On 7 November 2017 at 13:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> On Tue, Nov 07, 2017 at 01:22:19PM +0000, Ard Biesheuvel wrote:
>>> On 7 November 2017 at 12:56, Heyi Guo <heyi.guo@linaro.org> wrote:
>>>> From: Peicong Li <lipeicong@huawei.com>
>>>>
>>>> Flash region needs to be set as cacheable (write back) to increase
>>>> performance, if PEI is still XIP on flash or DXE FV is decompressed
>>>> from flash FV. However some ARM platforms do not support to set flash
>>>> as inner shareable since flash is not normal DDR memory and it will
>>>> not respond to cache snoop request, which will causes system hang
>>>> after MMU is enabled.
>>>>
>>>> So we need a new ARM memory region attribute WRITE_BACK_NONSHAREABLE
>>>> for flash region on these platforms specifically. This attribute will
>>>> set the region as write back but not inner shared.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Peicong Li <lipeicong@huawei.com>
>>>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
>>>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
> Pushed as 829633e3a82d. Thanks!
>
>>>> ---
>>>> ArmPkg/Include/Library/ArmLib.h | 7 +++++++
>>>> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 4 ++++
>>>> 2 files changed, 11 insertions(+)
>>>>
>>>> diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
>>>> index 24ffe9f..38199be 100644
>>>> --- a/ArmPkg/Include/Library/ArmLib.h
>>>> +++ b/ArmPkg/Include/Library/ArmLib.h
>>>> @@ -41,6 +41,13 @@ typedef enum {
>>>> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_UNCACHED_UNBUFFERED,
>>>> ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK,
>>>> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK,
>>>> + // On some platforms, memory mapped flash region is designed as not supporting
>>>> + // shareable attribute, so WRITE_BACK_NONSHAREABLE is added for such special
>>>> + // need.
>>>> + // Do NOT use below two attributes if you are not sure.
>>>> + ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE,
>>>> + ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE,
>>>> +
>>>> ARM_MEMORY_REGION_ATTRIBUTE_WRITE_THROUGH,
>>>> ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_THROUGH,
>>>> ARM_MEMORY_REGION_ATTRIBUTE_DEVICE,
>>>> diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>>>> index 8bd1c6f..4b62ecb 100644
>>>> --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>>>> +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
>>>> @@ -35,6 +35,10 @@ ArmMemoryAttributeToPageAttribute (
>>>> )
>>>> {
>>>> switch (Attributes) {
>>>> + case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK_NONSHAREABLE:
>>>> + case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK_NONSHAREABLE:
>>>> + return TT_ATTR_INDX_MEMORY_WRITE_BACK;
>>>> +
>>>> case ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK:
>>>> case ARM_MEMORY_REGION_ATTRIBUTE_NONSECURE_WRITE_BACK:
>>>> return TT_ATTR_INDX_MEMORY_WRITE_BACK | TT_SH_INNER_SHAREABLE;
>>>> --
>>>> 2.7.2.windows.1
>>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-08 1:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 12:56 [PATCH] ArmPkg/ArmMmuLib: Add new attribute Heyi Guo
2017-11-07 12:56 ` [PATCH] ArmPkg/ArmMmuLib: Add new attribute WRITE_BACK_NONSHAREABLE Heyi Guo
2017-11-07 13:22 ` Ard Biesheuvel
2017-11-07 13:29 ` Leif Lindholm
2017-11-07 13:30 ` Ard Biesheuvel
2017-11-08 1:56 ` Heyi Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox