From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D07E721DFA7A8 for ; Fri, 31 Mar 2017 03:52:04 -0700 (PDT) Received: by mail-it0-x22d.google.com with SMTP id y18so10463909itc.0 for ; Fri, 31 Mar 2017 03:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zzYpgCmKc6sWSjbhtv9HLFiYyf4jzAEXcgkVlHq0++0=; b=euGahEi9EFqfBZD/YsT8siBjeUsMh6EJqP/hbojTvegdXQM8hIVv3ycJ5kTk8ktF2x I3zyXTPkkCkOeVtPiAYr5bunrrSeiuCzZy17zw1VSbMUuXen7oy1zwpS2sNlXFSy7JA6 GLooGes9SXsLZZgJxQ4e0bZUvpdlQ+m9IX4Zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zzYpgCmKc6sWSjbhtv9HLFiYyf4jzAEXcgkVlHq0++0=; b=Nfc4Duw+nMsxU5SD3hLP/tYZ7LXuRjC2PzWm9eQQq7w8btP0oBWsnIx7y0L5WHhe1S X2Ru+7wOp2/rn400hgEjvqLhRDAzmWuZuwlv6QYzKP9bxUNXlWQg+mYB+ZBoqeQQp1+g 2hKo4w7h497zAMcY/n4MmBx6ke9tRNfdfZ4SxrvrOhxfM28NkUhqMxLECzCYr+sdV1Dk WZciOqaJDLVclZrtCMzNb6lCJB0ThtbzLYTXC5/2/QCnhKf+rvtmKC2g6efbeoiwGlfm 6PLbel58cQvj+D/4Y+Zk6NWwpO7DtIYHyWEbDaJiaOBGgdIn0kImXWz+AAlRlx+3vT3z GQ8w== X-Gm-Message-State: AFeK/H1MWXXJv7gM4v8NiA6bju9rj/x39dFWpPFzqc/u8cZ6fQmw/LuZwsaEITiXjjqR2V/ygFE6BTVTlXQA7c+d X-Received: by 10.36.31.202 with SMTP id d193mr2248212itd.37.1490957524170; Fri, 31 Mar 2017 03:52:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Fri, 31 Mar 2017 03:52:03 -0700 (PDT) In-Reply-To: References: <20170329175039.29635-1-ard.biesheuvel@linaro.org> <18095962-76eb-7337-969d-4f6080dff4d7@redhat.com> <41a87740-7634-bfde-d2fb-3767a5c33140@redhat.com> From: Ard Biesheuvel Date: Fri, 31 Mar 2017 11:52:03 +0100 Message-ID: To: Marc Zyngier Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , Mark Rutland , Drew Jones , Jon Masters Subject: Re: [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 10:52:05 -0000 Content-Type: text/plain; charset=UTF-8 On 31 March 2017 at 10:20, Marc Zyngier wrote: > On 30/03/17 09:40, Ard Biesheuvel wrote: >> On 29 March 2017 at 20:35, Laszlo Ersek wrote: >>> On 03/29/17 21:10, Ard Biesheuvel wrote: >> [...] >>>> >>>> How on earth is having two ways to disable ACPI rather than one going >>>> to cause fragmentation? Unlike v1, this patch does not allow you to >>>> expose both DT and ACPI tables at the same time. >>> >>> Oopsie daisy. You actually updated the commit message too. (I have now >>> formally diffed v1 vs. v2, including commit msg -- I generally do that >>> when reviewing incremental versions of patches, but it has been a very >>> long day, and I failed to get my mind off the track set up by v1). I got >>> really no good explanation for missing the fundamental logic change >>> between v1 and v2. As you say, version 2 preserves the mutual exclusion >>> between DT and ACPI that I'm so annoyingly obsessed about. Thank you for >>> the update. >>> >>> Reviewed-by: Laszlo Ersek >>> >> >> Thanks Laszlo. I am glad we have a solution we can both live with. >> >> I will wait for Marc to confirm that this works as expected for him. > > [ This email won't make it on the edk2 list because it filters out > non-subscribers. Boo! ] > > This patch does a very good job at restoring a functionality I'd have > otherwise lost. So for the record: > > Tested-by: Marc Zyngier > Acked-by: Marc Zyngier > Thanks all. Pushed as 7e5f1b673870, with the commit log expanded to explain how to remove the variable again (as requested by Laszlo)