From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4A0D121197051 for ; Thu, 6 Dec 2018 08:53:50 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id z7so2431858iti.0 for ; Thu, 06 Dec 2018 08:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5vL83Bh8XGukvEHrhMVJa4YJyzZyleeArhD5XdYkbrU=; b=Njgy5iqd+VvIP6BxF/yYumEddAmoggkxgtgSAb2tT9NbSkAm3rtgiF3VqI3L5KfMDx cAHu0K3mhcXv0Sa12WYrZR39I2yswRIeaYOs1tnTf7qX3bvzIYnH2Pw4MH4Qxl6QcjE7 qJ2CMevY9Loy4vxMUn+oQbeH136yHjP9kNhXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5vL83Bh8XGukvEHrhMVJa4YJyzZyleeArhD5XdYkbrU=; b=AFjnNoRrYP6hcBPNQReVVq9EzuvbaMpHs1ziWGEEM8DtxU1+nSUBjmrOreXU8A/bQ3 BiKUTDItuKecZ9XInEIsqTCYQOR7GJVavwjJ/2GDE6Xtw5gO87EjvqDwR9jTvelvuyV7 fZIwGvtj3WHOSfpFLuYx3dvg9z4FLJtlPIxv2XJtZQZEtB1L+AoP+DlVvIO8a02cNewg h60kDBAlyMqhQrHhTYQqVfOuTrmDqAxXPp0n2+ghIDdCY1cAuAxQHy1GIWq7niowdrUd 78v30d/rTjEnsZvpmseBKZTUk8cl/amnhtGM33bJhQdAKuuuniiELLbuPGuKgvAz+Wfu AiZA== X-Gm-Message-State: AA+aEWacCDWuvo76hbIKCyHqYiFYyyOacSWe3zXbdDeotMpKkSjobpgD 08sU2Lemq5CQB96C002iAMZXIUW/gRRkbk2JhpkK1g== X-Google-Smtp-Source: AFSGD/VNY3cr783M1Tp1XRT6kmbgHtB8iR1Lao9GIjqwwuq6Fls3OzKQVpQ1H70bWo20svIvVOyOFO3QNhGYjEo8W4U= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr20246545itk.71.1544115229411; Thu, 06 Dec 2018 08:53:49 -0800 (PST) MIME-Version: 1.0 References: <51b70aa08f34e31ac4e19bebdc96d5298691e9ba.1543437347.git.jbrasen@nvidia.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 6 Dec 2018 17:53:36 +0100 Message-ID: To: Jeff Brasen Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Girish Pathak Subject: Re: [PATCH v2] ArmPkg/ArmScmiDxe: Add clock enable function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 16:53:50 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 6 Dec 2018 at 01:37, Jeff Brasen wrote: > > Leif/Ard, > > > Any comments on this v2 patch for this? > > Hi Jeff, I'm not sure what level of bikeshedding is justified when it comes to a driver such as this one, which is very recent, and mostly for platform internal use. However, I will note that the current versioning approach permits a *client* of the old SCMI_CLOCK_PROTOCOL to be built that invokes ->Enable(), which is not defined for it. This somewhat defeats the purpose of the versioning, since the whole point is to avoid invoking ->Enable() on older implementations of the protocol. I'd be fine with just modifying the protocol, but if we decide we need versioning, we should not modify the public interface of the old one. How the driver reuses one implementation to back the other is another matter, of course.