From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 13C5B21E080EB for ; Thu, 19 Apr 2018 06:19:13 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id 71-v6so6630185ith.2 for ; Thu, 19 Apr 2018 06:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RXcjgulpF82Jxq20ZPeGeNS5NZv1Z1jlmI/3pXh0U9o=; b=XVuyY2e2j6u9ekht3V7WekUJ0F0glFtHvcm/yVErjcLLaGrxaWFnp0ApdqoFyAdr6e aNG4qXG8aLabFd2uDkvvmSYqbJlrpYvPs7P0Rhlzsb4tUWtt6YBvF5GdlUGJqkfmMTS5 nhY/rbUdRXsyQtmC6PdNENfoXPG6l5x78gkEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RXcjgulpF82Jxq20ZPeGeNS5NZv1Z1jlmI/3pXh0U9o=; b=iwJt6w0IPyCvw5wFHaRAwFeuITdtOT4fT+mGjgiuqTfSQstrtyII9bq5VNbjLppGpZ eONfU6BRVHgXiJzT1wVXIiG24XP93V6j/JgT7w63xaBLUE6TN87MZp2N5UNWHVCaIq+z h1QH1jqNOIvWOwQqkr+aP6FudVoamdNVx+8s0tb4pZRdb7MYT8Zy6yzW7vVRDrO+POm4 bXGtO5rSYWxSS9i/V1qgCb5eW/6cP1rq5CgWZpgvubsVQfVqh38YOypguFrjixuOGg6K shOfFrJEtvSUD0HtNQWBJynR3r+xz+nmcWIpVsnF6D5LONcDVXqNWkReGxxz6xZUusYp h/QQ== X-Gm-Message-State: ALQs6tAR/9YnsZ4qD67MbQXfyQ0CJuUMVTW/RNMhfr1NKtk84FQhqY16 NgB7+bMYsnZ2/n7FoU2ZkfGZxC5m3rXn3fMd5ccAVtefcNs= X-Google-Smtp-Source: AIpwx48NODsP4OTj89uWlxST0I4xr2TCNk+1RgK9g9mj0OpH5zxbY92ppvwp1DYWHvBm4NbgdSyEw3OK3RTnPscZZSE= X-Received: by 2002:a24:9456:: with SMTP id j83-v6mr6450261ite.50.1524143952323; Thu, 19 Apr 2018 06:19:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Thu, 19 Apr 2018 06:19:11 -0700 (PDT) In-Reply-To: <20180331003607.GB105567@SZX1000114654> References: <1522052735-68033-1-git-send-email-heyi.guo@linaro.org> <1522052735-68033-2-git-send-email-heyi.guo@linaro.org> <20180329000612.GA97590@SZX1000114654> <20180331003607.GB105567@SZX1000114654> From: Ard Biesheuvel Date: Thu, 19 Apr 2018 15:19:11 +0200 Message-ID: To: Guo Heyi Cc: "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm , Michael D Kinney Subject: Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 13:19:13 -0000 Content-Type: text/plain; charset="UTF-8" On 31 March 2018 at 02:36, Guo Heyi wrote: > Yes, it is https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix-v2 > > I just put in the cover letter :) > Pushed as a608c352766efbea4c32123d26073e10daf87d62 > On Fri, Mar 30, 2018 at 11:56:01AM +0100, Ard Biesheuvel wrote: >> On 29 March 2018 at 01:06, Guo Heyi wrote: >> > Ah, I made the change locally but forgot to send it out... >> > >> > Now it is there :) >> > >> >> Thanks. >> >> Do you have a repo link for the binary patch? >> >> >> >> > On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: >> >> On 26 March 2018 at 10:25, Heyi Guo wrote: >> >> > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it >> >> > is not necessary to maintain two different binary images for D03 and >> >> > D05 respectively. >> >> > >> >> > The main difference between D03 and D05 is the implementation of >> >> > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So >> >> > we switch to null DebugLib for release build and get a unified >> >> > Sm750Dxe binary. >> >> > >> >> > The code in SM750 driver treated the address returned from >> >> > PciIo->GetBarAttributes() as device address; this should be fixed >> >> > after edk2 commit dc080d3 since GetBarAttributes() returns host >> >> > address from then on. >> >> > >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Heyi Guo >> >> > Signed-off-by: Yi Li >> >> > Cc: Ard Biesheuvel >> >> > Cc: Leif Lindholm >> >> > Cc: Michael D Kinney >> >> >> >> Reviewed-by: Ard Biesheuvel >> >> >> >> Obviously, this requires a matching update in edk2-platforms, so >> >> please send that out and we can apply both at the same time. >> >> >> >> >> >> > --- >> >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- >> >> > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 >> >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes >> >> > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes >> >> > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes >> >> > 5 files changed, 32 deletions(-) >> >> > >> >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> >> > deleted file mode 100644 >> >> > index a2618331440f..000000000000 >> >> > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> >> > +++ /dev/null >> >> > @@ -1,32 +0,0 @@ >> >> > -#/** @file >> >> > -# >> >> > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. >> >> > -# Copyright (c) 2016, Linaro Limited. All rights reserved. >> >> > -# >> >> > -# This program and the accompanying materials >> >> > -# are licensed and made available under the terms and conditions of the BSD License >> >> > -# which accompanies this distribution. The full text of the license may be found at >> >> > -# http://opensource.org/licenses/bsd-license.php >> >> > -# >> >> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> >> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> >> > -# >> >> > -#**/ >> >> > - >> >> > - >> >> > -[Defines] >> >> > - INF_VERSION = 0x00010005 >> >> > - BASE_NAME = SmiGraphicsOutput >> >> > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 >> >> > - MODULE_TYPE = UEFI_DRIVER >> >> > - VERSION_STRING = 1.0 >> >> > - >> >> > - PCI_VENDOR_ID = 0x126F >> >> > - PCI_DEVICE_ID = 0x0750 >> >> > - PCI_CLASS_CODE = 0x030000 >> >> > - PCI_REVISION = 0xA1 >> >> > - COMPRESS = TRUE >> >> > - >> >> > -[Binaries] >> >> > - PE32|SmiGraphicsOutput.efi|* >> >> > - >> >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> >> > similarity index 100% >> >> > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf >> >> > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > deleted file mode 100644 >> >> > index 16c91e2b18ef..000000000000 >> >> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > deleted file mode 100644 >> >> > index b8de0259c785..000000000000 >> >> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> >> > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > new file mode 100644 >> >> > index 000000000000..3ae8ddfb647f >> >> > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ >> >> > -- >> >> > 2.7.4 >> >> >