From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B41D31A1DEF for ; Mon, 22 Aug 2016 01:48:59 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id n128so76441529ith.1 for ; Mon, 22 Aug 2016 01:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yjqa+GA5z8LftezsHnQuNu4tjRRL+lv+mnaL8tt/6jw=; b=ksxJL7L2i4D7X57berOy4EFaCVOpwkIp36aRyCLmW2vAVV9lQwCPQ0gSXDRdG0znuv TG8lakBoHRuZvgE/7wha8NHhXb0Rj6KingZQZNLdKoTUunftQgGyNOqdq8kMkRm5bQNd ogkzmDt3AaG+eIKK0RUL23AM9Wb8ti1/IimT0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yjqa+GA5z8LftezsHnQuNu4tjRRL+lv+mnaL8tt/6jw=; b=BBXyi7eXmzni+yAKsKv0qEOuZOV59zFcYoWqsmXsUyCrxzzKQZCxL1Dyv+YXugE5X8 Sz7PLwZygUEt3q/bL7Ezk1rYnrbvGSLP8j+Dk19zCSCZpQ6REC6Hy5YmOCPA5y9qxQBv 9vqVXJO8f2FKUSDilqZpPHxS0LMndk7ZbyKbu0aIk7kXoxEv7Ov5O9UUPcmNhFhIzjrL xnU0STRVG+zn/zeXxgzqXZZbzYjWlIKNieBKClLSiJ1Tg3uCQOFRMv0tA/pWpmIkpe5H vdILcwTpKSOEt3rJV0AmuroUnxOz3bM4VPc1dQMNCLan+RlKtI9vdXo1Gjti62B0TEcM jKMA== X-Gm-Message-State: AEkoousKBTa/MCOa7pr/Tgp9wn4yDO3T0Hy3QWtMvs9hEQ3v3aJMx3UHkOqWgYwjeE0ieTjhTNobvOiBHQ0uB29+ X-Received: by 10.36.214.193 with SMTP id o184mr20446131itg.5.1471855738964; Mon, 22 Aug 2016 01:48:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 22 Aug 2016 01:48:58 -0700 (PDT) In-Reply-To: References: <1471589755-24419-1-git-send-email-vikas.cha.sajjan@hpe.com> <09a7a387-da85-655f-c7bc-4904af75540c@redhat.com> From: Ard Biesheuvel Date: Mon, 22 Aug 2016 10:48:58 +0200 Message-ID: To: "Sajjan, Vikas C" Cc: Laszlo Ersek , "edk2-devel@ml01.01.org" , "leif.lindholm@linaro.org" , "Wei, Dong (Office of the CTO)" Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 08:49:00 -0000 Content-Type: text/plain; charset=UTF-8 On 22 August 2016 at 10:01, Sajjan, Vikas C wrote: > > Hi Ard, > > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Monday, August 22, 2016 12:46 PM > To: Sajjan, Vikas C > Cc: Laszlo Ersek ; edk2-devel@ml01.01.org; leif.lindholm@linaro.org; Wei, Dong (Office of the CTO) > Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms > > On 22 August 2016 at 09:07, Ard Biesheuvel wrote: >> On 20 August 2016 at 05:01, Sajjan, Vikas C wrote: >>> >>> >>> -----Original Message----- >>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>> Sent: Friday, August 19, 2016 6:58 PM >>> To: Sajjan, Vikas C ; >>> edk2-devel@ml01.01.org; ard.biesheuvel@linaro.org; >>> leif.lindholm@linaro.org >>> Cc: Wei, Dong (Office of the CTO) >>> Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg >>> platforms >>> >>> On 08/19/16 08:55, Vikas C Sajjan wrote: >>>> This series adds ramdisk driver support to ArmVirtPkg platforms. >>>> It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. >>>> >>>> changes since v2: >>>> - Made changes as suggested by Laszlo Ersek >>>> a] Moved inclusion of AcpiTableDxe.inf to end of file >>>> b] Moved gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol to proper location >>>> c] fixed minor nits >>>> >>>> changes since v1: >>>> - Made changes as suggested by Laszlo Ersek >>>> a] clarified in the commit message (including the subject line) >>>> that this patch is actually about adding the RAM Disk driver to the >>>> ArmVirtPkg platforms, not just the NFIT reporting feature of the driver >>>> b] enabled feature for all of ArmVirtQemu, ArmVirtQemuKernel, and ArmVirtXen. >>>> c] prepended a patch to the series that extracts >>>> "MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf" >>>> from all of the DSC files, into "ArmVirt.dsc.inc" >>>> >>>> >>>> Vikas C Sajjan (2): >>>> ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc >>>> ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms >>>> >>>> ArmVirtPkg/ArmVirt.dsc.inc | 17 +++++++++++++++++ >>>> ArmVirtPkg/ArmVirtQemu.dsc | 1 - >>>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++ >>>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - >>>> ArmVirtPkg/ArmVirtRules.fdf.inc | 2 ++ >>>> ArmVirtPkg/ArmVirtXen.dsc | 1 - >>>> ArmVirtPkg/ArmVirtXen.fdf | 5 +++++ >>>> 7 files changed, 29 insertions(+), 3 deletions(-) >>>> >>> >>> Series >>> Reviewed-by: Laszlo Ersek >>> >>> Thank you, Laszlo. >>> >>> Ard, can you please commit the series for Vikas? My brain is fried, I >>> need to get out. :) >>> >>> Thanks! >>> Laszlo >> >> Committed as >> >> fde03c8065ea ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to >> ArmVirt.dsc.inc >> d36447418d32 ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms >> > > These patches have no broken ArmVirtXen, since it has no resolution for FileExplorerLib, which RamDiskDxe depends on. > > Could you propose a fix please? > > My bad, > I somehow missed the below line in ArmVirtPkg/ArmVirt.dsc.inc > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > > Will send out v4 now. > Hello Vikas, I already committed your v3 patches. So instead of a v4, could you please propose a new patch that fixes ArmVirtXen.dsc? Thanks, Ard.