From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08AB02034A890 for ; Fri, 27 Oct 2017 02:19:10 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id m81so11338295ioi.13 for ; Fri, 27 Oct 2017 02:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UmTVOoSSOtOh2j+TjDEJcfxslIQ3MlTYb7MqEwSQy6s=; b=bUuyU5mrzBJOkEVi0VxVzTeNVHxBdh33C19NgOsMl3CiABw+/8vi1mTXbieIvY5bVO 8qopEJhIWzydlCMD45BB8h9sa2NIzzgXiEZHQ7H03GgigfItoONXfv53OSdmWqznr6Vv 5u714qvbFmXRzBt+gPXWsk+lAg+thOo6WolFg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UmTVOoSSOtOh2j+TjDEJcfxslIQ3MlTYb7MqEwSQy6s=; b=KvG6pcwinCu5d3SnyKgGw3g33tDMUfXJpoFt3Yf1iwBHeFoqwGbqN5VsB/gKYnbkHP mRWRczn83Gg9fEuictbX9el/gZw9fDHM7CMcFPghHduyBVzVl8mcb7H/yLHxqE73BzhR 6Gx8ephzAh55uocn0XnUF9IOqmYG5e+MhydUynYVOEyGBWnVav66z1LtkMhmFVx3A+1A umQWxQ3toRitybb5EZ2gsUw0QT+eoMVhT2sl0Wsc5LhkdCMbnZvrtSn3tArKBtlRbx/3 Tn3h0h1zYFMnuX8hQ8Z7FqcziW6+855zpRbQyQAfJlPDCiMFazIvE+PJvPmrL2hv7O7O muFQ== X-Gm-Message-State: AMCzsaV045C+/sOyrXDz0fsUouCRW17K6Z4nFv5mmfelVQPltE4B9mdK 2hhooDHc6K9hbkNUwDkxnCf+TMThTaRhA4xsFh7FtQ== X-Google-Smtp-Source: ABhQp+RaIpxvn+ZwhuwladRJYpxC+Zh62XYS7iGmcBskUoBdIDR7IZBj4yH2M5nT/6cjVa371/OG5Yi20cbSn4tlCwk= X-Received: by 10.107.142.208 with SMTP id q199mr35189692iod.186.1509096177482; Fri, 27 Oct 2017 02:22:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Fri, 27 Oct 2017 02:22:55 -0700 (PDT) In-Reply-To: <20171027053326.48815-2-daniil.egranov@arm.com> References: <20171027053326.48815-1-daniil.egranov@arm.com> <20171027053326.48815-2-daniil.egranov@arm.com> From: Ard Biesheuvel Date: Fri, 27 Oct 2017 10:22:55 +0100 Message-ID: To: Daniil Egranov Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 1/4] Drivers/SataSiI3132Dxe: Fixed PCI IO read and write operations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 09:19:11 -0000 Content-Type: text/plain; charset="UTF-8" On 27 October 2017 at 06:33, Daniil Egranov wrote: > The ATA pass through read should use PCI IO bus master write operation > and ATA pass through write should use PCI IO bus master read operation > as the read and write operations executed from the bus master's point > of view. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Daniil Egranov Reviewed-by: Ard Biesheuvel > --- > EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > index 2fb5fd68db..a938563ebd 100644 > --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > @@ -104,7 +104,7 @@ SiI3132AtaPassThruCommand ( > } > > Status = PciIo->Map ( > - PciIo, EfiPciIoOperationBusMasterRead, > + PciIo, EfiPciIoOperationBusMasterWrite, > Packet->InDataBuffer, &InDataBufferLength, &PhysInDataBuffer, &PciAllocMapping > ); > if (EFI_ERROR (Status)) { > @@ -139,7 +139,7 @@ SiI3132AtaPassThruCommand ( > OutDataBufferLength = Packet->OutTransferLength * SataDevice->BlockSize; > > Status = PciIo->Map ( > - PciIo, EfiPciIoOperationBusMasterWrite, > + PciIo, EfiPciIoOperationBusMasterRead, > Packet->OutDataBuffer, &OutDataBufferLength, &PhysOutDataBuffer, &PciAllocMapping > ); > if (EFI_ERROR (Status)) { > -- > 2.11.0 >