Re: [PATCH edk2-platforms v2] Silicon/Openmoko: add driver for ChaosKey RNG USB device

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 24 August 2017 at 16:45, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Aug 24, 2017 at 01:14:48PM +0100, Ard Biesheuvel wrote:
>> This is a continuation of the work carried out by Leif Lindholm to
>> implement a driver for the ChaosKey USB device. This driver uses the
>> UEFI driver model, which is a slightly awkward fit, due to the fact
>> that a UEFI implementation may legally only instantiate those protocols
>> that are needed to access the device path that the active Boot####
>> options refers to.
>>
>> However, it is expected that UEFI implementations typically instantiate
>> all USB I/O protocols and connect them as well, as those are required
>> for a USB keyboard to be able to control the boot sequence. This should
>> result in this driver being connected and given the opportunity to
>> produce the EFI_RNG_PROTOCOL.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> On the whole, this looks good to go, with one exception: it doesn't
> currently build on ARM.
>
> If you fold in:
>
> diff --git a/Silicon/Openmoko/Openmoko.dsc
> b/Silicon/Openmoko/Openmoko.dsc
> index 295ff6514..2b6ffe894 100644
> --- a/Silicon/Openmoko/Openmoko.dsc
> +++ b/Silicon/Openmoko/Openmoko.dsc
> @@ -35,5 +35,8 @@
>    UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
>    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> +[LibraryClasses.ARM]
> +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +
>  [Components]
>    Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed as 5d5ce02ebadedf9fbaa0fec610735cb64c30276e with this hunk folded in.