From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 007962095AE41 for ; Thu, 24 Aug 2017 11:24:50 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id s132so406892ita.1 for ; Thu, 24 Aug 2017 11:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y4QJ5bXRWOwUza3FEEHBhLsP5I5Ss6+xnknXb2u3lYY=; b=e/Xf5VDeyDeVXwHGAl57S6dDNuY4eWj4XsxQpn/W9YWG3CnBsdQWfxctaFwx5wKp8z McA11Jkj5y9qo67f4YMCDOJZRM3OYbOfliXPKgP4CKWowiE49O1IeA4kOUJA+hAESTSb UUnjz0ynFySuKDDPuP1AGmXgZYvUX3kMUvWLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y4QJ5bXRWOwUza3FEEHBhLsP5I5Ss6+xnknXb2u3lYY=; b=MjyX/0pcH7I9gYz6Rxz0iiCSBPmImkOXTOs69+R67hHdwuwGRi0RvjFRAjIYSmPCVx MP6i3AC1iHZoCE2Er7rwLKY8WAZMQh1QoF1XTixhdGh7uvPTkXfvY5HkbM9KY6h0Ql9O sZeESgP4N22zmfniejk9E1+RUxvxtC10ZQwOJbcCPdHj6DQ2yVZ2pT/v99hkTAVTEsx3 MofFilwyCo1i6t41gJCWizDz/LBd0YIoYBOyeUSAWmyO5CGl2AlFF3Hmv/le6m6l1Bkl K6yEyYswu1FM9kj8+MJD94ix9wjWhaamw3HmmDTqM0Q1pCB1JnEs2ezyCMh3Ax+0rooy +HpQ== X-Gm-Message-State: AHYfb5iQxNj2+zBWFIvBR/H1V2za4n6v4jk7OjLElCWj1LY/hAsKBKbi o5F5F06TyyvSh/0Ms1lAIJT+otcBFvSy X-Received: by 10.36.43.68 with SMTP id h65mr6727938ita.41.1503599244433; Thu, 24 Aug 2017 11:27:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Thu, 24 Aug 2017 11:27:24 -0700 (PDT) In-Reply-To: <20170824154549.dz4e6tuyj5vslffh@bivouac.eciton.net> References: <20170824121448.9283-1-ard.biesheuvel@linaro.org> <20170824154549.dz4e6tuyj5vslffh@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 24 Aug 2017 19:27:24 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" Subject: Re: [PATCH edk2-platforms v2] Silicon/Openmoko: add driver for ChaosKey RNG USB device X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 18:24:50 -0000 Content-Type: text/plain; charset="UTF-8" On 24 August 2017 at 16:45, Leif Lindholm wrote: > On Thu, Aug 24, 2017 at 01:14:48PM +0100, Ard Biesheuvel wrote: >> This is a continuation of the work carried out by Leif Lindholm to >> implement a driver for the ChaosKey USB device. This driver uses the >> UEFI driver model, which is a slightly awkward fit, due to the fact >> that a UEFI implementation may legally only instantiate those protocols >> that are needed to access the device path that the active Boot#### >> options refers to. >> >> However, it is expected that UEFI implementations typically instantiate >> all USB I/O protocols and connect them as well, as those are required >> for a USB keyboard to be able to control the boot sequence. This should >> result in this driver being connected and given the opportunity to >> produce the EFI_RNG_PROTOCOL. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > On the whole, this looks good to go, with one exception: it doesn't > currently build on ARM. > > If you fold in: > > diff --git a/Silicon/Openmoko/Openmoko.dsc > b/Silicon/Openmoko/Openmoko.dsc > index 295ff6514..2b6ffe894 100644 > --- a/Silicon/Openmoko/Openmoko.dsc > +++ b/Silicon/Openmoko/Openmoko.dsc > @@ -35,5 +35,8 @@ > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > +[LibraryClasses.ARM] > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > + > [Components] > Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDxe.inf > > Reviewed-by: Leif Lindholm > Pushed as 5d5ce02ebadedf9fbaa0fec610735cb64c30276e with this hunk folded in.