public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Matt Sealey <neko@bakuhatsu.net>
Subject: Re: [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name
Date: Wed, 2 May 2018 10:07:58 +0200	[thread overview]
Message-ID: <CAKv+Gu8Z9RAhLpjP6Lh+tHZPsT3ay2LLvmtukVx969OMJSdvYg@mail.gmail.com> (raw)
In-Reply-To: <20180501175505.qfabi2yhf3wo6d3j@bivouac.eciton.net>

On 1 May 2018 at 19:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote:
>> Rename the variable holding the Styx PPTT table to mStyxPpttTable.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as 0db6171fb5a63e8d58ee7cfdecf36f5c57ce9315

>> ---
>>  Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> index d9d7c494d86f..1746bbe8b596 100644
>> --- a/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> +++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> @@ -156,7 +156,7 @@ typedef struct {
>>    }                                                                           \
>>  }
>>
>> -STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {
>> +STATIC STYX_PPTT_TABLE mStyxPpttTable = {
>>    {
>>      AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
>>                      STYX_PPTT_TABLE,
>> @@ -221,5 +221,5 @@ PpttHeader (
>>    VOID
>>    )
>>  {
>> -  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;
>> +  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;
>>  }
>> --
>> 2.17.0
>>


      reply	other threads:[~2018-05-02  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 16:32 [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name Ard Biesheuvel
2018-05-01 17:55 ` Leif Lindholm
2018-05-02  8:07   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu8Z9RAhLpjP6Lh+tHZPsT3ay2LLvmtukVx969OMJSdvYg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox