public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name
@ 2018-05-01 16:32 Ard Biesheuvel
  2018-05-01 17:55 ` Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-05-01 16:32 UTC (permalink / raw)
  To: edk2-devel, leif.lindholm; +Cc: jeremy.linton, neko, Ard Biesheuvel

Rename the variable holding the Styx PPTT table to mStyxPpttTable.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c
index d9d7c494d86f..1746bbe8b596 100644
--- a/Silicon/AMD/Styx/AcpiTables/Pptt.c
+++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c
@@ -156,7 +156,7 @@ typedef struct {
   }                                                                           \
 }
 
-STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {
+STATIC STYX_PPTT_TABLE mStyxPpttTable = {
   {
     AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
                     STYX_PPTT_TABLE,
@@ -221,5 +221,5 @@ PpttHeader (
   VOID
   )
 {
-  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;
+  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;
 }
-- 
2.17.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name
  2018-05-01 16:32 [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name Ard Biesheuvel
@ 2018-05-01 17:55 ` Leif Lindholm
  2018-05-02  8:07   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-05-01 17:55 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel, jeremy.linton, neko

On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote:
> Rename the variable holding the Styx PPTT table to mStyxPpttTable.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c
> index d9d7c494d86f..1746bbe8b596 100644
> --- a/Silicon/AMD/Styx/AcpiTables/Pptt.c
> +++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c
> @@ -156,7 +156,7 @@ typedef struct {
>    }                                                                           \
>  }
>  
> -STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {
> +STATIC STYX_PPTT_TABLE mStyxPpttTable = {
>    {
>      AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
>                      STYX_PPTT_TABLE,
> @@ -221,5 +221,5 @@ PpttHeader (
>    VOID
>    )
>  {
> -  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;
> +  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;
>  }
> -- 
> 2.17.0
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name
  2018-05-01 17:55 ` Leif Lindholm
@ 2018-05-02  8:07   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-05-02  8:07 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel@lists.01.org, Jeremy Linton, Matt Sealey

On 1 May 2018 at 19:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote:
>> Rename the variable holding the Styx PPTT table to mStyxPpttTable.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as 0db6171fb5a63e8d58ee7cfdecf36f5c57ce9315

>> ---
>>  Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> index d9d7c494d86f..1746bbe8b596 100644
>> --- a/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> +++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c
>> @@ -156,7 +156,7 @@ typedef struct {
>>    }                                                                           \
>>  }
>>
>> -STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {
>> +STATIC STYX_PPTT_TABLE mStyxPpttTable = {
>>    {
>>      AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
>>                      STYX_PPTT_TABLE,
>> @@ -221,5 +221,5 @@ PpttHeader (
>>    VOID
>>    )
>>  {
>> -  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;
>> +  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;
>>  }
>> --
>> 2.17.0
>>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-02  8:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-01 16:32 [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name Ard Biesheuvel
2018-05-01 17:55 ` Leif Lindholm
2018-05-02  8:07   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox