From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0477621E47D4D for ; Tue, 29 Aug 2017 08:45:55 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id d81so21921782ioj.4 for ; Tue, 29 Aug 2017 08:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gt4+WwgOADCLP8CyPo27ams0SIfnrXz8aHJP3UnBtKk=; b=eQB2WyfXVFXWbVEAft6Y3mh8pIUEecjP/nX+TXzTLOiFvzJ+xH9UZ/FsnzQJrzCixf Eaik8xWTma9lkDiKBBLHP1SJJaki5AQ3bHSkUMapeZ2lf+1s1AuTNqJaQBeMtrI+j5TQ gZtiZhnq7rsuM4vi+DmQGl9ElC3cbcQYWG2eM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gt4+WwgOADCLP8CyPo27ams0SIfnrXz8aHJP3UnBtKk=; b=FL08U8C5XrO3WRMh35WHVTDjLEtR0oJSUBGduw8GaoKK0SgPF2C+zk2Xf+LbcUXL1/ xHNM8AJqVtswjiiw7CFevzh5S/bJLL0GB+fHiiuDDOuyAB9Hi0M/5mdQAiSDsWOGodQe oz5i/bni4u89KGM+W6vXgDJa2YhhDwiY5BXJmrQENglPFmb/lnp58n7/TL20sGqaelaF YgoFGcMdyiR3SyxKtxLcXPZEJAM1i98rj+2jyiIaRmgez/6HC+0+hNxqR6KiuIwtAWU+ 24mWagxTbpJlVkEsST94/MVgrNk9wD73u2N+z+/A0qIXIAhjqLt8czBsMzKBO8gy2k7L dcdA== X-Gm-Message-State: AHYfb5hFzhybUNA/oZimFA5usGYJDfoMAb5YZujfBhYXiuhjQOATPIGz DOL0YKDGj4QF2kdaeiecaoRiLxksHkq+ X-Received: by 10.107.16.218 with SMTP id 87mr4353130ioq.149.1504021715044; Tue, 29 Aug 2017 08:48:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 08:48:34 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 16:48:34 +0100 Message-ID: To: Marcin Wojtas Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 15:45:55 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 16:47, Marcin Wojtas wrote: > 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>> Instead of hardcoding the non-cache coherent nature of this device >>> by invoking UncachedMemoryAllocationLib directly for allocating >>> shared buffers, switch to DmaLib, which encapsulates this at a >>> more abstract level. This allows the driver to be shared with >>> platforms that are cache coherent (by simply switching to another >>> DmaLib implementation), and removes the hardcoded dependency on >>> UncachedMemoryAllocationLib, which will be removed from upstream >>> EDK2. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >> >> Ah, and there is the non-bogus fix :) >> Reviewed-by: Leif Lindholm > > Please let me just run this on the HW before merge - I'll do it tomorrow. > Sure. Note that you will need to sync EDK2 after I merged the DmaLib changes (which I will do today)