From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FD992098EAB8 for ; Thu, 2 Aug 2018 12:02:55 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id j81-v6so3315147ite.0 for ; Thu, 02 Aug 2018 12:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CUvRMpNjZ3jT30gZfkMCfi/rmQS6jvQC0wPvG4+pr2E=; b=ImzfTLWV9Xoxay/KiIyQTpDVOWfxcv8D+cg4na2OAs6vfdVmLujmCAf+okviUxywMa abFJ1rJug0E0LwNygQrnTwILcIxlli2JtEyN5vcjfCZ4vihxeJ2SRjZzfgZ8pFHfTrez 0weYkMj0edWPW7/3dIcITYEL4rvSOHBiOO2LY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CUvRMpNjZ3jT30gZfkMCfi/rmQS6jvQC0wPvG4+pr2E=; b=AU0uiaNduDzjrdrtKfJnv2WpvrhAEyC3/Hz1eEYghlhIht7z+TsIjAiU3FW9eLNlfA ayFu3k/PI0Mvh2p+ABm80Tf7pJKjsxDCC4l3WgGTPkt/MaaerJQSUq2dsXs3OD7WWMrR ucQ6EBFYd3G6nTgQl3svqFw9sVYHsJH5PSEk9Qq64kact/tjlMBODCBXklp+bpr3wb8m ZRGXAjofPwZ2/ZhiR2IPVdditwRuBwzIm0GbRgWIgWCPRc01CI1/e0a8GVJXSbETlOSb VQI3ASxUVQ4EQkvt8zu8Rp1hYFyUvTF/LvIQkkJk4xGeCX8eoW/vnE/qa+LC1bP7I7vH 4Eaw== X-Gm-Message-State: AOUpUlHug1m91fKufq6r2xQIsGR6B9f/bnWFJtUGEEwZbaGcpbjJkVom bXxLGlyF9qz/MvVo8zefKRnq8u1GLb/R32kSwLlpB+n6mLs= X-Google-Smtp-Source: AAOMgpdsTLe/TugmAi6QPt/GseJ75FnQOZIQKgFRKEcIO1nS/jY/yWWBzzk5YQv9+AC6p/TU5ikkSsUTKMLZxVqvHls= X-Received: by 2002:a24:148c:: with SMTP id 134-v6mr3804128itg.50.1533236574377; Thu, 02 Aug 2018 12:02:54 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Thu, 2 Aug 2018 12:02:53 -0700 (PDT) In-Reply-To: <1532589696-16902-1-git-send-email-mw@semihalf.com> References: <1532589696-16902-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Thu, 2 Aug 2018 21:02:53 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH v2 0/6] Armada7k8k ComPhy rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 19:02:55 -0000 Content-Type: text/plain; charset="UTF-8" On 26 July 2018 at 09:21, Marcin Wojtas wrote: > Hi, > > The second version of the patchset brings minor corrections, > that were pointed out during review. Details can be found > int the commit logs. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/comphy-upstream-r20180726 > > I'm looking forward to review and any comments/remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2 > * 1/6 > - improve commit message > - create dedicated header for externally defined SiP services > ComPhy parameters > - add comments about external definitions > > * 2,3,4/6 > - s/firmware/ARM-TF/ in the commit messages > > * 5,6/6 > - swap order without any changes in the patches - in the first > series compilation was broken on 5th and immediately fixed in > the last patch. Now every patch compiles. > > Grzegorz Jaszczyk (5): > Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF > Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF > Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF > Marvell/Library: ComPhyLib: Configure USB in ARM-TF > Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config > Marvell/Library: ComPhyLib: Clean up the library after rework > Reviewed-by: Ard Biesheuvel Pushed as 016d55843a01..9dae9a0c7996 Thanks! > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 23 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 2 +- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.h | 22 - > Silicon/Marvell/Include/Library/SampleAtResetLib.h | 7 - > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 512 +----- > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h | 86 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.c | 19 - > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 1777 +------------------- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 41 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c | 132 -- > 10 files changed, 170 insertions(+), 2451 deletions(-) (/me does a little dance after reading this line) > create mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c > > -- > 2.7.4 >