From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D980B211A43A1 for ; Thu, 20 Dec 2018 00:46:47 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id a6so1695752itl.4 for ; Thu, 20 Dec 2018 00:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hLA29iQe8/x0e6hesoyoG3manFPb7ye2Vm5c1oV7zLE=; b=VlxX4N1mTqoGRaNSg2EOB8Te5nk8RmdjxjWTYE9qnGWFXU2xFRo31OOcQQeOai2MxF IvM1mJFfFNVoJ0DLo5Jnhxcd4y2H64k8gJFogMYdeWR1ziUplRt2zCSWtxmbSuuMYu/O orEcXLG+Lj3B9T6VLN/HIgq9hUUyOPHOhiSmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hLA29iQe8/x0e6hesoyoG3manFPb7ye2Vm5c1oV7zLE=; b=sAaG87zmACHrjbg1+CJWoUy0QsQRjWgZE8/ux2YtAUr6dQiV8oNOjh29mnaCcR5fQz H9Yb1rthJer0uRhg+lmmCHl0P8aZAfXFQEKOF04k7Ro5ze2OmhZDjJpJvhayM9o9t19z s/dZ3NpZxfbeB6Vg0j+BhuaDYinyMsyJ4NcUc6Q781CCL+n18zDFd2BWoVPsbv6/25He 5nEBMrjMASgC7aCklkMfg8yUCHf6ly4ppxtzZry92PSleCNd0UXExos9WpfjJ8b3K18F F9qPvjNvsVt2HMKjXVWd1+Y/nVPKznUgR8dGtEQZu280EjkfHkF/DFBVg/vd9fE6L1YW s00g== X-Gm-Message-State: AA+aEWZeEjWMtNg7VvI1l73CquD3cS31Uq9JRG9ysRav0Z2Sr3heLOjt o6XO7JEUZKfn+q2lXrxpcL0L5HxVxTGqE7W24YP5Jg== X-Google-Smtp-Source: AFSGD/X3X/suxh8K219Ki2drbLTF+FAKZ33pM+q6y/RUQlD5ol1Gqg4edETYRNguvL89CSsPF2W1qLL+F65SEiEWeCg= X-Received: by 2002:a02:183:: with SMTP id 3mr22693344jak.130.1545295606232; Thu, 20 Dec 2018 00:46:46 -0800 (PST) MIME-Version: 1.0 References: <1545284878-21417-1-git-send-email-sughosh.ganu@arm.com> <1545284878-21417-2-git-send-email-sughosh.ganu@arm.com> In-Reply-To: <1545284878-21417-2-git-send-email-sughosh.ganu@arm.com> From: Ard Biesheuvel Date: Thu, 20 Dec 2018 09:46:34 +0100 Message-ID: To: Sughosh Ganu Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v2 1/3] Platform/ARM/SgiPkg: Build infrastructure for StandaloneMm image X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 08:46:48 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu wrote: > > Add the build infrastructure for compilation of StandaloneMm image > files and FD file. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sughosh Ganu > --- > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 130 +++++++++++++++++++++++++++ > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 100 +++++++++++++++++++++ > 2 files changed, 230 insertions(+) > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > create mode 100644 Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > new file mode 100644 > index 000000000000..4615c383c46a > --- /dev/null > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > @@ -0,0 +1,130 @@ > +# > +# Copyright (c) 2018, ARM Limited. All rights reserved. > +# > +# This program and the accompanying materials are licensed and made available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > + > +################################################################################ > +# > +# Defines Section - statements that will be processed to create a Makefile. > +# > +################################################################################ > +[Defines] > + PLATFORM_NAME = sgi_mm_standalone Please use camel case > + PLATFORM_GUID = 34B78C8F-CFD5-49D5-8360-E91143F6106D > + PLATFORM_VERSION = 1.0 > + DSC_SPECIFICATION = 0x00010011 > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > + SUPPORTED_ARCHITECTURES = AARCH64|ARM Does this actually build for ARM? > + BUILD_TARGETS = DEBUG|RELEASE Please include NOOPT > + SKUID_IDENTIFIER = DEFAULT > + FLASH_DEFINITION = Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > + DEFINE DEBUG_MESSAGE = TRUE > + > + # LzmaF86 > + DEFINE COMPRESSION_TOOL_GUID = D42AE6BD-1352-4bfb-909A-CA72A6EAE889 > + > +################################################################################ > +# > +# Library Class section - list of all Library Classes needed by this Platform. > +# > +################################################################################ > +[LibraryClasses] > + # > + # Basic > + # > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > + DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > + FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf > + HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > + MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > + ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf > + > + # > + # Entry point > + # > + StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > + > +[LibraryClasses.AARCH64] Are the pieces below specific to AARCH64? If not, drop the [] section header > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > + StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > + ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > + CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > + PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > + > + # ARM PL011 UART Driver > + PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf > + PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > + SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > + > + StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > + > +################################################################################ > +# > +# Pcd Section - list of all EDK II PCD Entries defined by this Platform > +# > +################################################################################ > +[PcdsFeatureFlag] > + gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|TRUE > + > +[PcdsFixedAtBuild] > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF > + gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff > + gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f > + > +[PcdsFixedAtBuild.AARCH64] Same here > + ## PL011 - Serial Terminal > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x7FF70000 > + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 > + > +################################################################################################### > +# > +# Components Section - list of the modules and components that will be processed by compilation > +# tools and the EDK II tools to generate PE32/PE32+/Coff image files. > +# > +# Note: The EDK II DSC file is not used to specify how compiled binary images get placed > +# into firmware volume images. This section is just a list of modules to compile from > +# source into UEFI-compliant binaries. > +# It is the FDF file that contains information on combining binary files into firmware > +# volume images, whose concept is beyond UEFI and is described in PI specification. > +# Binary modules do not need to be listed in this section, as they should be > +# specified in the FDF file. For example: Shell binary (Shell_Full.efi), FAT binary (Fat.efi), > +# Logo (Logo.bmp), and etc. > +# There may also be modules listed in this section that are not required in the FDF file, > +# When a module listed here is excluded from FDF file, then UEFI-compliant binary will be > +# generated for it, but the binary will not be put into any firmware volume. > +# > +################################################################################################### > +[Components.common] > + # > + # MM Core > + # > + StandaloneMmPkg/Core/StandaloneMmCore.inf > + > +[Components.AARCH64] > + StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > + > +################################################################################################### > +# > +# BuildOptions Section - Define the module specific tool chain flags that should be used as > +# the default flags for a module. These flags are appended to any > +# standard flags that are defined by the build process. They can be > +# applied for any modules or only those modules with the specific > +# module style (EDK or EDKII) specified in [Components] section. > +# > +################################################################################################### > +[BuildOptions.AARCH64] > +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp Please indent two spaces > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > new file mode 100644 > index 000000000000..6b9d1e703869 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf > @@ -0,0 +1,100 @@ > +# > +# Copyright (c) 2018, ARM Limited. All rights reserved. > +# > +# This program and the accompanying materials are licensed and made available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > + > +################################################################################ > +# > +# FD Section > +# The [FD] Section is made up of the definition statements and a > +# description of what goes into the Flash Device Image. Each FD section > +# defines one flash "device" image. A flash device image may be one of > +# the following: Removable media bootable image (like a boot floppy > +# image,) an Option ROM image (that would be "flashed" into an add-in > +# card,) a System "Flash" image (that would be burned into a system's > +# flash) or an Update ("Capsule") image that will be used to update and > +# existing system flash. > +# > +################################################################################ > + > +[FD.BL32_AP_MM] > +BaseAddress = 0xff200000|gArmTokenSpaceGuid.PcdFdBaseAddress # UEFI in DRAM + 128MB. > +Size = 0x00e00000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the device (64MiB). > +ErasePolarity = 1 Indent ^^ > + > +# This one is tricky, it must be: BlockSize * NumBlocks = Size Please drop the silly line above > +BlockSize = 0x00001000 > +NumBlocks = 0x0e00 > + indent ^^^ > +0x00000000|0x00280000 > +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > +FV = FVMAIN_COMPACT > + > +[FV.FVMAIN_COMPACT] > +FvAlignment = 16 > +ERASE_POLARITY = 1 > +MEMORY_MAPPED = TRUE > +STICKY_WRITE = TRUE > +LOCK_CAP = TRUE > +LOCK_STATUS = TRUE > +WRITE_DISABLED_CAP = TRUE > +WRITE_ENABLED_CAP = TRUE > +WRITE_STATUS = TRUE > +WRITE_LOCK_CAP = TRUE > +WRITE_LOCK_STATUS = TRUE > +READ_DISABLED_CAP = TRUE > +READ_ENABLED_CAP = TRUE > +READ_STATUS = TRUE > +READ_LOCK_CAP = TRUE > +READ_LOCK_STATUS = TRUE Indent ^^ > + > +INF StandaloneMmPkg/Core/StandaloneMmCore.inf > +INF StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > + Indent ^^ > +################################################################################ > +# > +# Rules are use with the [FV] section's module INF type to define > +# how an FFS file is created for a given INF file. The following Rule are the default > +# rules for the different module type. User can add the customized rules to define the > +# content of the FFS file. > +# > +################################################################################ > + > + > +############################################################################ > +# Example of a DXE_DRIVER FFS file with a Checksum encapsulation section # > +############################################################################ > +# > +#[Rule.Common.DXE_DRIVER] > +# FILE DRIVER = $(NAMED_GUID) { > +# DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > +# COMPRESS PI_STD { > +# GUIDED { > +# PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > +# UI STRING="$(MODULE_NAME)" Optional > +# VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > +# } > +# } > +# } > +# > +############################################################################ > + > +[Rule.Common.MM_CORE_STANDALONE] > + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > + PE32 PE32 Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > + } > + > +[Rule.Common.MM_STANDALONE] > + FILE MM_STANDALONE = $(NAMED_GUID) { > + SMM_DEPEX SMM_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > + PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > + UI STRING="$(MODULE_NAME)" Optional > + VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > + } > -- > 2.7.4 >