From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24FF91A1EC2 for ; Tue, 6 Sep 2016 23:50:05 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id e124so6027235ith.0 for ; Tue, 06 Sep 2016 23:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xdc4jTHjnQSH1Ai/IkXTP+XlIkpAyIeemO9i7y6YIHc=; b=RrgRQ+n5NaTKLIf7ItshthPDERPg7UOVfv+tB71P5KhN89HoPaBy7GZapI1hhHyovI c9tlxI8Vd9mrspADYvIsYJRhZB9aXp8FzdPODsigmxlyEmTYq07PrLkt4t2itQYkXltH gPn93SssVWG/1zK1gLVtHvGUDKEahQQCnVfk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xdc4jTHjnQSH1Ai/IkXTP+XlIkpAyIeemO9i7y6YIHc=; b=m2PXQWxQGeqeT4VXmByk/X45Sm0OsdnrjT2dfvbawU2XOfZPMFetcGSzuT7Qh6IK8v 3NdVhW7uQelFQRPVgQh+bK/cO3kRFpBoKWv927+3BF1I0yJisBZLsCnmD4gJB4oSdTHL DjNrDL1YR5x0nMLawh4VG17T+DXug7ZtSYiaAhEem+1rBtECSuwVP+BTc25qtH4VvkZK J00Q9tUqs2otbiXggEJaocfGqqNiEJNIcrE5anzseRG0y1aVovYXY78Q4aTYNGinUUMB ULGRo8hqTlwaEDCyhi6gxMvZz3vVs30DOK6S5xRX1kU8UDR1fjWm3U0r8vqXtibvjpnf 4EgA== X-Gm-Message-State: AE9vXwPp8jI6T8TZX8xQM95ulyqqC0HBg6aGlRj6fKidaJjqDZwmJWfhBHPmSmxJxTcSD/kD0bq8pvXDAEfjyZ4C X-Received: by 10.36.214.193 with SMTP id o184mr4141134itg.5.1473231004465; Tue, 06 Sep 2016 23:50:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Tue, 6 Sep 2016 23:50:04 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E2F42@shsmsx102.ccr.corp.intel.com> References: <1473171813-24595-1-git-send-email-ard.biesheuvel@linaro.org> <1473171813-24595-2-git-send-email-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E2F42@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 7 Sep 2016 07:50:04 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Kinney, Michael D" Subject: Re: [PATCH v2 1/3] MdePkg/BaseMemoryLib: widen aligned accesses to 32 or 64 bits X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 06:50:05 -0000 Content-Type: text/plain; charset=UTF-8 On 7 September 2016 at 04:03, Gao, Liming wrote: > Ard: > In InternalMemSetMem, Value64 = (((UINT64)Value32) << 32) | Value32; may cause the below link error with VS IA32 build. It (<<) should be replaced by BaseLib LShift API > > BaseMemoryLib.lib(SetMem.obj) : error LNK2001: unresolved external symbol __allshl > I should have tested this more thoroughyl, apologies for wasting your time. I send out a v3 Thanks, Ard.