From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EC1A2233377D for ; Tue, 23 Jan 2018 10:12:28 -0800 (PST) Received: by mail-io0-x243.google.com with SMTP id f34so1902376ioi.13 for ; Tue, 23 Jan 2018 10:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2rQlFXlVXIoY1ff1a6DbqRAhu5VWweOwAr1zpzDv+Sw=; b=IbiryuSvkaeMe/iOQNG5ewqYgrRgAiZ80JaWlZScGAQFV36iCiNVP9bf7NLOtwP4hu YfCp1/vqSpybTut23NUbAZ2agcRFQHhzDKILbKp16UO/5fbHM68c8ea2B30RhaswyNGL AbAtp6S8K1ATlmZynlBAzjBRnPjUE6IgtlVQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2rQlFXlVXIoY1ff1a6DbqRAhu5VWweOwAr1zpzDv+Sw=; b=DFEzeVO1pkNmg9OU1lNtFs5Z+g5/Xa8fnO45DthYqRKUagI+EOftlXbHNsapZBdi56 nyez5yW3LzI+qH5pN0XwLvRjVYbgGQAvTCcZmDkRaHdP7sTAnsa2SbLb53l155mpCvDJ m0379iZrfWbZO/g9ih4y2dYYzH6YpWWXHuey1eLDe3l9nRRHL91oRKnXl17s8sIjxhJX YHIhsuBegFxS1TC3E+WlGDHerbIyTtFd7SBpkKAKpv/xchVYbHXFns+WdRtdLn4ZMyDJ lz8+413Y8x45dVSYIpRS/GhZz5LbnYHhC64w8CmwDtK8pgyJG4BQ+MH3rLCYTiGM6YXE I3HA== X-Gm-Message-State: AKwxyte43iP3H0Zm3cRBcULBYbKrH8zox8/6EaFQq2cPtp7h0shRqilA WRQfb4ra4LAVCffXnz5jVHgee+rKbuyY8CVQ5ldTfg== X-Google-Smtp-Source: AH8x226gYXAOfrgQ/1INIAI+/PGMkp+spz1BKlNNtcHtVQBjyr/ojLGXcN3tMokYk7TMVNU5kQ+jFkXS5uvp122jKoM= X-Received: by 10.107.6.161 with SMTP id f33mr5130746ioi.196.1516731475193; Tue, 23 Jan 2018 10:17:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Tue, 23 Jan 2018 10:17:54 -0800 (PST) In-Reply-To: References: <20180122165905.10368-1-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Tue, 23 Jan 2018 18:17:54 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"Alexei.Fedorov@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH] Platform/ARM: Fix flash alignment access X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 18:12:29 -0000 Content-Type: text/plain; charset="UTF-8" On 22 January 2018 at 17:27, Ard Biesheuvel wrote: > On 22 January 2018 at 16:59, wrote: >> From: Alexei Fedorov >> >> Flash memory is mapped as device memory and should use only aligned >> accesses. >> Update VariableRuntimeDxe from using BaseMemoryLibOptDxe to the generic >> BaseMemoryLib which provides aligned memory access only. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Alexei Fedorov >> Signed-off-by: Evan Lloyd > > Reviewed-by: Ard Biesheuvel > Pushed as 88e967c5d2f0 Thanks guys >> --- >> Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + >> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 3 ++- >> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 1 + >> 3 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc >> index 5c2a29fe8330bbf308e31e34b617517a5aebcf6d..9d7317683ef39ab47429234b98d94c04953b41cb 100644 >> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc >> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc >> @@ -234,6 +234,7 @@ [Components.common] >> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { >> >> NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf >> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> } >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> >> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> index 1f612cc282eb8bf4fdc74ff0933c36ecf70c6daf..6c6c8d3938e61abf7456b4c2cd6b464c0238353b 100644 >> --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc >> @@ -1,5 +1,5 @@ >> # >> -# Copyright (c) 2012-2015, ARM Limited. All rights reserved. >> +# Copyright (c) 2012-2017, ARM Limited. All rights reserved. >> # Copyright (c) 2015, Intel Corporation. All rights reserved.
>> # >> # This program and the accompanying materials >> @@ -215,6 +215,7 @@ [Components.common] >> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { >> >> NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf >> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> } >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> index 3dbc105f6f8a565da34807508ac8178e4d524e41..295e9a126b0ebaa4653d7e25e2f7d8c396403764 100644 >> --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc >> @@ -224,6 +224,7 @@ [Components.common] >> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { >> >> NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf >> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> } >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf >> -- >> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >>