From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1491E220C1C5F for ; Thu, 30 Nov 2017 06:58:22 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id b5so8636593itc.3 for ; Thu, 30 Nov 2017 07:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TUJYKsU6kw0MQSGf1mwQUSHqMzS2bbLBRG0ehleLE+E=; b=JcCwb4iKFwI3rBm1pXAHCi1WrI7l3oKE8UI1fGL86YTkEbNawNUUO6GW+a3xP+O1TP iq5Kuvw7gWtAB8JPzNu/NgXfszP52o1+qCibUyq9333cMauyppxPWujC9MCbNK0HNE34 1SreMRVmhToTHrMc7jUxNyq8cKqJSABBfftNM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TUJYKsU6kw0MQSGf1mwQUSHqMzS2bbLBRG0ehleLE+E=; b=qwRWKQaH/QV0dMCnw1vOy3topKm3tVsf+fM3UGyaxqwU9v1EQx+hKGttRXNVYxpryx SNjJUhv0XSS7zXnqArn5BneVy7BQGYaOs1RETw5CG3RfN1GaKXRlZgug5nj3Ohf6ABeM fWhp4NFNqrSYDobI97bZZwHMAMvXP9U7moomqkW2zXUda7d17uIcAaMRHznRxOwfI0+7 fv/WzVF0QdJkeMSD8Gv8MWGYiUPt3OmdqlbYihDioXgP857GJNUYh4HKj40oeRfKABIE 5BtlEesnucG6vRNkAz2I0pqD6d+Vhjyeenux8Q7DmoEfnjQQS4VLOrjy3JvJ59MvHLip 0wCA== X-Gm-Message-State: AJaThX7cFYA6jg1yu7bH2Mb78SRLf0LNYrUlqXqI+0a/Tf2J/8Zyb7Pw 5I7VlJculPOHzOzmJiJN2Q5ZUHUmheOQmbeuX0tWIEq8 X-Google-Smtp-Source: AGs4zMbZ6RlYCxlymvvqqnxmw9+h+giskWD6MRRoFoVAdx8l1WAWGaXtmmHMW157M8Lp2UhFs3tIaGdALhxhUhYCcK0= X-Received: by 10.36.55.138 with SMTP id r132mr3506899itr.34.1512054167761; Thu, 30 Nov 2017 07:02:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Thu, 30 Nov 2017 07:02:47 -0800 (PST) In-Reply-To: <20171130150116.30044-1-leif.lindholm@linaro.org> References: <20171130150116.30044-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 15:02:47 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform: drop tftp shell support from remaining platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 14:58:23 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 15:01, Leif Lindholm wrote: > Cello, Overdrive, Overdrive1000 and Armada still include the > now-defunct library implementation of the Shell tftp command. > Since the command is a nonstandard one anyway, just remove > it from the build for these platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 - > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 - > Platform/Marvell/Armada/Armada.dsc.inc | 1 - > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 - > 4 files changed, 4 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 2cc71d499e..51d823892b 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -745,7 +745,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > index 33e9ebee32..fb9155ce3a 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -667,7 +667,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 0c873fb112..95268ac587 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -489,7 +489,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > NULL|Platform/Marvell/Applications/EepromCmd/EepromCmd.inf > NULL|Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf > NULL|Platform/Marvell/Applications/FirmwareUpdate/FUpdate.inf > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index 5352fc4e55..0abec8120a 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -684,7 +684,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > -- > 2.11.0 >