From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements
Date: Fri, 14 Feb 2020 09:02:44 +0000 [thread overview]
Message-ID: <CAKv+Gu8be3o=e2m3=DKn5AVgCdUHVemrjRq447z2bG8wZcOm3Q@mail.gmail.com> (raw)
In-Reply-To: <20200108170004.6680-1-pete@akeo.ie>
On Wed, 8 Jan 2020 at 18:00, Pete Batard <pete@akeo.ie> wrote:
>
> This series of patches improves the reporting of the firmware version
> and platform serial number for the Raspberry Pi platforms.
>
> Since there is only so much we can do with 16 bits and the firmware revision
> reported by the VideoCore mailbox is really a timestamp of when the VC
> firmware was build, we convert it to a YY.MM revision, which should be good
> enough for our purpose, which is indicational and end-user readable.
>
> A serial number fix is also needed as RPi4 platforms appear to report
> 0x0000000010000000 as the board serial, so the case where we fell back to
> the MAC address when the board serial is 0 needs to be amended.
>
> Pete Batard (2):
> Platform/RPi/SmbiosDxe: Report a more human readable firmware revision
> Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 314c45bc620b..9369b01e86ad
Thanks!
> Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 20 ++++++++++++--------
> Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 ++
> Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 5 +++--
> 3 files changed, 17 insertions(+), 10 deletions(-)
>
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2020-02-14 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 17:00 [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements Pete Batard
2020-01-08 17:00 ` [edk2-platforms][PATCH 1/2] Platform/RPi/SmbiosDxe: Report a more human readable firmware revision Pete Batard
2020-01-20 14:08 ` Philippe Mathieu-Daudé
2020-01-08 17:00 ` [edk2-platforms][PATCH 2/2] Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4 Pete Batard
2020-01-09 14:44 ` Ard Biesheuvel
2020-01-09 15:02 ` Pete Batard
2020-01-20 13:50 ` Pete Batard
2020-02-14 9:02 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8be3o=e2m3=DKn5AVgCdUHVemrjRq447z2bG8wZcOm3Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox