From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.3877.1581670977488840780 for ; Fri, 14 Feb 2020 01:02:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nRyqSUqe; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id u6so10027751wrt.0 for ; Fri, 14 Feb 2020 01:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IEIff4tCezb4/9Zp2fwKajmKAWekKwdBKwD3xA7PCU8=; b=nRyqSUqesodPkgFsGtD9aU8K845Nax4ot5SNQffhMksid/fubDG2HgQ8Ng4O7cduXT QNP7aW41bQdV8c6MrX5iGS+YmSge8oQHUqRKEdYTOgnnjkSTkg5BOx6KgOc3mYmqrh/O 198xUfdsxp97d+fgud3OEMiqNUP0cA4R2gNBwHUlGubR8L7RP9b74jFP0OGT+dpQVpS3 bzrdc9+3ZJvzavGZCyjLC550rtHVxRpUXqvme9mVz3bZBUhkBFR0WOfMRrdSQgHU1Cgt q+gkgcvBMIEb2QYIDq2kEq9mkb+45gW5h2RjE6WXAXZWdXdRaVnIQskTegpmTKYpU7xJ HPIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IEIff4tCezb4/9Zp2fwKajmKAWekKwdBKwD3xA7PCU8=; b=s474SALD7zJEFfmbECBiN+Oj7VSWBjkTBJoDCxNjRtnDMpLGuY2HdPbqY4GDacpGwi 5MRS+Tco6UwqBcXSkDz7LZRosWhfiyq+m+N+9djPWPO70VIomdmeTSkTeCsqkpMyvE63 3LaKeh/Xif+bjz9eFMouOGhYEbn5sHGBvx0z5/cL9m7xTNbd+7i5anSwceQA/qyfjjEt qTNueSwVjIo8jmdaZsfq3De6VMTMcTRk8I3dIuSMRWQBZNDl5VYPfvHpRHlQy6fa55IT AvHtnDE/3uQIOZbyAdRKCLSdX/ADo62gX98Wgy4MMUhZT5K1NrsJy8m39AZYxRx970oi Mb6w== X-Gm-Message-State: APjAAAX95Be1WBRlMRmGEqjSmFHggl2qPhuFk7ym5l2nRlB7rbjeVxtz oSDhN7O1Be6TeDfEa7excqZLGWshUTkvIbvx9FqCUA== X-Google-Smtp-Source: APXvYqxTl1W6mzEG62I/X8tPUFDn9wJJexPUMQCl5jjecf5O3SI32ZQx8zT/Pr+K6iC6T9LTUfrcIyHFgIrcF4mdvIQ= X-Received: by 2002:a5d:6a4b:: with SMTP id t11mr2862812wrw.262.1581670975902; Fri, 14 Feb 2020 01:02:55 -0800 (PST) MIME-Version: 1.0 References: <20200108170004.6680-1-pete@akeo.ie> In-Reply-To: <20200108170004.6680-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Fri, 14 Feb 2020 09:02:44 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Wed, 8 Jan 2020 at 18:00, Pete Batard wrote: > > This series of patches improves the reporting of the firmware version > and platform serial number for the Raspberry Pi platforms. > > Since there is only so much we can do with 16 bits and the firmware revision > reported by the VideoCore mailbox is really a timestamp of when the VC > firmware was build, we convert it to a YY.MM revision, which should be good > enough for our purpose, which is indicational and end-user readable. > > A serial number fix is also needed as RPi4 platforms appear to report > 0x0000000010000000 as the board serial, so the case where we fell back to > the MAC address when the board serial is 0 needs to be amended. > > Pete Batard (2): > Platform/RPi/SmbiosDxe: Report a more human readable firmware revision > Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4 > Reviewed-by: Ard Biesheuvel Pushed as 314c45bc620b..9369b01e86ad Thanks! > Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 20 ++++++++++++-------- > Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 ++ > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 5 +++-- > 3 files changed, 17 insertions(+), 10 deletions(-) > > -- > 2.21.0.windows.1 >