From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C50D21959CB2 for ; Sun, 23 Dec 2018 06:56:59 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id z7so13315902iti.0 for ; Sun, 23 Dec 2018 06:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKqemyFyy2mfhpJrcAMFqbDgUsjrQDMtG93BKPoSUec=; b=E+x+hNG7m0ss9ub7qww1+7MN45EO0FXe1bG/pNKBMidt6vM4Ty7WsLPyGXrKh42lQ7 fbhOC9RUzT96Nx+u61Hn9Y/pyaIG9ouhJigb+ExxZecwMnZy6weotmNtQ8jWFSxdNeP6 cPDVPO7nZ+Ihh1se6ELDeood6CH6JeFOZ/5r0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKqemyFyy2mfhpJrcAMFqbDgUsjrQDMtG93BKPoSUec=; b=ImbV9TgaVP9WLO/4Jv8dSgS/XT/9gZzbJwflih6MUv5ik0g0HWDSCh19nONoTWl4qJ O2AE2KhAq4coHsMIQDQ2GMyKtOP/Z/3M+qGyCjn3rcd+XYqzsWqs2351+ydd1g1DeaA+ 6Ymi+KdGC3i8xwhOExV4/d8NMIeVUtwMB3Nlkt5GnLH8B4+3i7q7QKlfuqmMDClx8pHj 89AML1RUrwtaMdeHhT//yNJnHUcULr7SxZ+YS+0kQVG5n6+dsAS5jzfXJYr5y+/+0+f0 VVmedsJjy2IQBD6GVdvbopiOy9x+LVne8rjU0/1GyCqzYt8KbbItzjAxZpyyWzrDbept Kg0Q== X-Gm-Message-State: AA+aEWagcdFS52qoQhU8ccVBmv9+NKiGW0/ansTFIoi91paNTF248Tmz yqYsQCLPYcQGOWMJnV+YU9q4o1HeEdwLLyKca4CVww== X-Google-Smtp-Source: AFSGD/UxialRM+wdvrRG0qQcIFvttCqlANcs5z+ZD2pGhyD1nXWikigbS0/SojWytVE2XDptJrN72AiC02qva0Dz70g= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr6976513itk.71.1545577018881; Sun, 23 Dec 2018 06:56:58 -0800 (PST) MIME-Version: 1.0 References: <20181220110332.30145-1-ard.biesheuvel@linaro.org> <20181222120304.6gan6eh7voc554h5@bivouac.eciton.net> In-Reply-To: <20181222120304.6gan6eh7voc554h5@bivouac.eciton.net> From: Ard Biesheuvel Date: Sun, 23 Dec 2018 15:56:46 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , "Gao, Liming" Subject: Re: [PATCH v2] BaseTools/tools_def ARM: use softfloat target for CLANG3x X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2018 14:57:00 -0000 Content-Type: text/plain; charset="UTF-8" On Sat, 22 Dec 2018 at 13:03, Leif Lindholm wrote: > > On Thu, Dec 20, 2018 at 12:03:32PM +0100, Ard Biesheuvel wrote: > > The 'arm-linux-gnueabihf' target triplet we use for CLANG35 and > > CLANG38 specifies a hardfloat target, and so the binaries that are > > emitted are annotated as using VFP registers for passing floating > > point arguments, even though no VFP is used anywhere in the code. > > > > This works fine as long as we don't try to link against code > > that uses software floating point, but combining object files > > with different floating point calling conventions is not permitted. > > > > So switch to the softfloat arm-linux-gnueabi triplet instead. > > This affects both the name Clang uses when invoking the linker, > > and the arguments it passes to it, and we are mostly interested > > in the latter (since any version of GNU ld.bfd will do the right > > thing as long as it targets EABI ARM) > > > > For native builds, this change has no effect, since the unprefixed > > system linker will take priority, and so Clang will pass the right > > arguments to whichever linker happens to be the system linker. > > > > For cross builds, the fact that Clang composes the name of the > > linker by prefixing '-ld' with the target triplet implies that > > users will have to switch to a version of binutils that targets > > arm-linux-gnueabi rather than arm-linux-gnueabihf. Note that the > > GCCx toolchain targets can use either when building for ARM so this > > does not create a need to install two versions of the ARM cross > > toolchain. Also, note that all ARM toolchains in the GCC family > > are already documented as requiring a toolchain that targets > > arm-linux-gnueabi and not arm-linux-gnueabihf. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks all Pushed as 559a07d84e5a..41203b9ab5d4 > > --- > > v2: improve commit log > > > > BaseTools/Conf/tools_def.template | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > > index 902680c24c85..f7eb87af14c2 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -5231,7 +5231,7 @@ RELEASE_GCC5_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20 > > *_CLANG35_*_DLINK_PATH = ENV(CLANG35_BIN)clang > > *_CLANG35_*_ASLDLINK_PATH = ENV(CLANG35_BIN)clang > > > > -DEFINE CLANG35_ARM_TARGET = -target arm-linux-gnueabihf > > +DEFINE CLANG35_ARM_TARGET = -target arm-linux-gnueabi > > DEFINE CLANG35_AARCH64_TARGET = -target aarch64-linux-gnu > > > > DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-empty-body -Wno-unknown-warning-option > > @@ -5384,7 +5384,7 @@ NOOPT_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) -O0 > > ################## > > # CLANG38 ARM definitions > > ################## > > -DEFINE CLANG38_ARM_TARGET = -target arm-linux-gnueabihf > > +DEFINE CLANG38_ARM_TARGET = -target arm-linux-gnueabi > > DEFINE CLANG38_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) DEF(CLANG38_ARM_TARGET) DEF(CLANG38_WARNING_OVERRIDES) -mno-movt > > DEFINE CLANG38_ARM_DLINK_FLAGS = DEF(CLANG38_ARM_TARGET) DEF(GCC_ARM_DLINK_FLAGS) > > > > -- > > 2.19.2 > >