Re: [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 22 February 2018 at 13:08, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Feb 20, 2018 at 05:49:38PM +0000, Ard Biesheuvel wrote:
>> This adds support for using the random number generator in the Atmel
>> AtSha204a over I2C. Other functionality of the chip is currently
>> unsupported.
>>
>> Note that the the I2C support in this device essentially violates the
>> protocol layering, by requiring that the device is woken up by driving
>> SDA low for a certain amount of time, which is something that cannot be
>> expressed in terms of an I2C packet sent to the device's slave address.
>> Instead, the slave address 0x0 is added to the device's address array,
>> and the wake is sent by sending a dummy write to address 0x0, and
>> ignoring the subsequent error. This requires the I2C bus to be clocked
>> at 100 kHz.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> All of my feedback from v1 has been addressed, so:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Thanks.

Pushed as 487015fb23c1a40f0d05240cadde4faf979483ee