From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8DEEF22436935 for ; Fri, 23 Feb 2018 07:27:21 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id m22so10172295iob.12 for ; Fri, 23 Feb 2018 07:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+Efz3NnXBUakz9nkdtt7FakDHdy2+THFZrsDa1qSwLU=; b=duQK1/q6KWgnk/iCmNtqO+z9Xwp5eoJPUe7Z8uho06I1r9PS+JuJA4hz9I7WfS7SAc BELPklAU3yB7Lae9G7wlbL+uOBq+GYLBNJrU+Cad7j3BgWK/74IOtsaejroZzvA8pB7F RrOZ9MHE+jnmqJ8xkgwgJtVJOZwfFFVy1odg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+Efz3NnXBUakz9nkdtt7FakDHdy2+THFZrsDa1qSwLU=; b=KIypyCtLR9xGkq4VD58AKjgMMHLVuYNxjDdc4vN7M21CFSLQXMkF1uv8jhFpJEKImN dRyJADCDTqXgYk0E5g9VZPohUquCk92FPHt5RwG4uaU3R3/pXQreCR7eW+mKqzzJFT/r cD45qZqeEK3ThiFwGB/z1Y2t6D3pOZIYm709zS1bMuCigC5Rsi08SjzKJCA1m5dlYYpC RkslJaVh1twRekzywn9uCR59HBg9cRVy4FaMgm51edBCmaIS5s3gVEg3PU/a7DHeDumG sXSOkpZxe0/WF1/vO2yNoFkY2qf36Bqgxu2CLOmxB4MmwtjyYIDsUTQyd80Ag6S9tY3b PAvw== X-Gm-Message-State: APf1xPDeKnrwqa7BJuv/NUXTHtVEI7gRXloUkWps/nFNrt6dGl67872B LlfarQiQnxO6Ma5sEm1A5PmeyA2vlrnmliovxud0rpEE7Bw= X-Google-Smtp-Source: AG47ELu3zLbjLEjL6aZuiWmPZ49IzZNM59FBuEGcvhwNMwBJh8r9q/LyVtrYF+Rsbbge8VMOLYFjBFvMtgm46vSGqRw= X-Received: by 10.107.56.69 with SMTP id f66mr2165951ioa.170.1519400002546; Fri, 23 Feb 2018 07:33:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Fri, 23 Feb 2018 07:33:21 -0800 (PST) In-Reply-To: <20180222130842.hhiuvxaupr4zpg3z@bivouac.eciton.net> References: <20180220174944.525-1-ard.biesheuvel@linaro.org> <20180220174944.525-2-ard.biesheuvel@linaro.org> <20180222130842.hhiuvxaupr4zpg3z@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 23 Feb 2018 15:33:21 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 15:27:22 -0000 Content-Type: text/plain; charset="UTF-8" On 22 February 2018 at 13:08, Leif Lindholm wrote: > On Tue, Feb 20, 2018 at 05:49:38PM +0000, Ard Biesheuvel wrote: >> This adds support for using the random number generator in the Atmel >> AtSha204a over I2C. Other functionality of the chip is currently >> unsupported. >> >> Note that the the I2C support in this device essentially violates the >> protocol layering, by requiring that the device is woken up by driving >> SDA low for a certain amount of time, which is something that cannot be >> expressed in terms of an I2C packet sent to the device's slave address. >> Instead, the slave address 0x0 is added to the device's address array, >> and the wake is sent by sending a dummy write to address 0x0, and >> ignoring the subsequent error. This requires the I2C bus to be clocked >> at 100 kHz. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > All of my feedback from v1 has been addressed, so: > Reviewed-by: Leif Lindholm Thanks. Pushed as 487015fb23c1a40f0d05240cadde4faf979483ee