From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>
Cc: Andrew Fish <afish@apple.com>, "Ni, Ruiyu" <ruiyu.ni@intel.com>,
edk2-devel-01 <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: 'fastboot boot' TPL
Date: Wed, 28 Feb 2018 08:10:27 +0000 [thread overview]
Message-ID: <CAKv+Gu8d9uomB-X2uoecLLOSfhxiDVRbsr74R2U80YPsuPjd2g@mail.gmail.com> (raw)
In-Reply-To: <CAN9vWDJsQ+p2Do0CFsUc9b420agrFNF6KOv3MVJ0ycyDpJXRwA@mail.gmail.com>
On 28 February 2018 at 07:56, Michael Zimmermann
<sigmaepsilon92@gmail.com> wrote:
> I feel like both of you misunderstood my intention.
> As I said in my initial mail, I'm not arguing the spec - I know that
> StartImage must be called from TPL_APPLICATION.
>
> I'm just discussing a bug inside EmbeddedPkg/Application/AndroidFastboot -
> because they actually do call StartImage from TPL_CALLBACK.
I think the confusion is a result of the fact that you never mentioned
that particular module/file until now.
> As I proposed in my initial mail, we should not only fix that, but also add
> tpl ASSERTs inside several BootServices to prevent this from happening in
> future.
>
I agree. Did you run into any issues due to this?
next prev parent reply other threads:[~2018-02-28 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 6:06 'fastboot boot' TPL Michael Zimmermann
2018-02-28 7:29 ` Ni, Ruiyu
2018-02-28 7:33 ` Michael Zimmermann
2018-02-28 7:42 ` Andrew Fish
2018-02-28 7:56 ` Michael Zimmermann
2018-02-28 8:10 ` Ard Biesheuvel [this message]
2018-02-28 8:15 ` Michael Zimmermann
2018-02-28 8:19 ` Ard Biesheuvel
2018-02-28 10:10 ` Michael Zimmermann
2018-02-28 12:11 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8d9uomB-X2uoecLLOSfhxiDVRbsr74R2U80YPsuPjd2g@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox