From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22c; helo=mail-it0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E87C9223522AA for ; Wed, 28 Feb 2018 00:04:21 -0800 (PST) Received: by mail-it0-x22c.google.com with SMTP id k79so2456004ita.2 for ; Wed, 28 Feb 2018 00:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UHjiWs/ULGk212srnGFDrscv6O9bvoSzm4lWOC0RLfA=; b=Uy2QzyWE/uRnFdFi4YMgYLjkdps8CaAwIe9mC3SXsQ5NPIX5ebuPsc+lF+/1gDr+4A ofXbs2PpkgACXir4f5Sb+cEmxJQWRI5OfZF0+AjgBAvWJ4ZPRgczMEqRK3+lVLHYBDF7 7KMT2ehxkqIRmmyGCeoDvIWEYV1LEL+24HIbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UHjiWs/ULGk212srnGFDrscv6O9bvoSzm4lWOC0RLfA=; b=Nobds9YZc5mAS8h2+nwL2Fnnrv6cBLQREz/DKXIZxPQpn45tFz72s2nYrbfiQSQuky OAvfJvumfNIk1vIbrqiZKggBckLzJAX+AzpzntZUNnFHolCrAgqo2ZZ2263x1DGI0+GE pAOMCRr7go0CJUCAQJPgo4KdysaQTavp2Gte7XnMl8kQncRzwQVD/aYReEOQiUOpQklZ Unx7bmyuobKENcEmQapgvT3ydnmWb2o1jpdtijase09RjA+h1WrbfIxtF0i+xildrpxo XsBBl28KUQqPSRG+opTniT3EX6QlG7wXU4Fj1xBFJ0FlMD4m1kYgkFZ6683qp50RY4dH LM5A== X-Gm-Message-State: APf1xPBIpIZsm1mHegeiv7/tKqxXf+ZQ2XggbwhttSaP9WRo8QZgHnHr EYrm7mtXcHezahvqd3hBaLTgvUYstr5O+s9Cg7g3Hp6e X-Google-Smtp-Source: AG47ELugFlJVHceqyxRewQTpHn7cGMdcQ6gA2ZnVy09iatDHgm7Yx8m2BOuSKQOx8QDlEx7UWSlmI6Yzo6JW3jS0AP4= X-Received: by 10.36.90.5 with SMTP id v5mr20143438ita.138.1519805428216; Wed, 28 Feb 2018 00:10:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 28 Feb 2018 00:10:27 -0800 (PST) In-Reply-To: References: <26da6afd-102b-0006-c6b7-a10d8e13f96e@Intel.com> From: Ard Biesheuvel Date: Wed, 28 Feb 2018 08:10:27 +0000 Message-ID: To: Michael Zimmermann Cc: Andrew Fish , "Ni, Ruiyu" , edk2-devel-01 , Leif Lindholm Subject: Re: 'fastboot boot' TPL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 08:04:22 -0000 Content-Type: text/plain; charset="UTF-8" On 28 February 2018 at 07:56, Michael Zimmermann wrote: > I feel like both of you misunderstood my intention. > As I said in my initial mail, I'm not arguing the spec - I know that > StartImage must be called from TPL_APPLICATION. > > I'm just discussing a bug inside EmbeddedPkg/Application/AndroidFastboot - > because they actually do call StartImage from TPL_CALLBACK. I think the confusion is a result of the fact that you never mentioned that particular module/file until now. > As I proposed in my initial mail, we should not only fix that, but also add > tpl ASSERTs inside several BootServices to prevent this from happening in > future. > I agree. Did you run into any issues due to this?