From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=L6itB2U+; spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) by groups.io with SMTP; Wed, 29 May 2019 11:03:21 -0700 Received: by mail-it1-f194.google.com with SMTP id u186so5096942ith.0 for ; Wed, 29 May 2019 11:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+aNfvlA4nO0BgaOIsMysDvb/qUve2Utww0cjj8gYSAw=; b=L6itB2U+tYNHMO2d3vI8bSgrkdCR6WSsB4yTFhMMt6Jc5f9y+xzFL3aYHa03c6nQai 0T9SDS0yz0wrWYL3TwLjiQYxQh/QvWiFH4Usus4rPLcUdoJ8RBmwH0iIzN/sCX4bH7M1 hjVfBGyGw86/zE7XXH9nLfuGiboCyTCs8YxfWO5JBmLoUs0DFTDfvvhaJvcn0M3hIMtO FI624kxLpuP8Z+2tCg5tV5RRUfsyPRZHmW48TTlK7vI3Bv2STxyctNJSGtawBJnuf0j9 ReDqNlT8kJn7e2pnVMGn3ZiTzqMVSbLSJZ3r8cRDol5GwrwgxiTpBAOa9JPJ6PZ+nRFc OnHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+aNfvlA4nO0BgaOIsMysDvb/qUve2Utww0cjj8gYSAw=; b=Ql7itmMqCqSM9XK8Li1W7Bd1EwTLSc/rySQRSwFvoevvz91rbWfEVxUPlVznyCnw4K 1OViZDNKfR5rAPMBCRMN95eGpyd3pgmdWcnqcvDWdDIaPvXgt9T0TxCNfKLqMeSLIi1k j3dmxwLWTYBOTqMrHSntRoPpQpIUaSvFCWd1NPYL2ID1N7mr+jYylh1DP7U6yfyyNLFn jCQIJexdMmosaqaR+gv9jyHKwZCk3DfYWns0HKfKI12MN1txjHPJ+wlskxVWwuIxdNZe 7AZqzFwN12anjagpZyEKkCj4VfeoDfuG3P4QoZBi+kBSTs47k7+ul9zy5XjJVZM7WlAe J4dA== X-Gm-Message-State: APjAAAWwDFdcn9qQFDtjHZJpGF9t9tcInl7RkDSIa8wzL7uFtcj53QVR m7Em/zc4OGwMdyDHKC1NLXq9i8z/SukSx1WU5As+xw== X-Google-Smtp-Source: APXvYqx7TreAQU/vsgV6Dy+ZWS+qPWDu+c/1rHEIpbHgDSfld1wU/DKQNI/g1yxrnVPWlVhQMzN9Y6z2qlTdqjBoSZ0= X-Received: by 2002:a24:1614:: with SMTP id a20mr1957937ita.153.1559153000674; Wed, 29 May 2019 11:03:20 -0700 (PDT) MIME-Version: 1.0 References: <20190529125021.28308-1-ard.biesheuvel@linaro.org> <20190529125021.28308-4-ard.biesheuvel@linaro.org> <20190529130652.pkfzeo5xbcotypaf@bivouac.eciton.net> <20190529144353.lcg3f6ygnalkuatn@bivouac.eciton.net> In-Reply-To: <20190529144353.lcg3f6ygnalkuatn@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Wed, 29 May 2019 20:03:07 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/Secure96Dxe: redefine LS connector CS as platform property To: Leif Lindholm Cc: edk2-devel-groups-io , Masahisa Kojima Content-Type: text/plain; charset="UTF-8" On Wed, 29 May 2019 at 16:43, Leif Lindholm wrote: > > On Wed, May 29, 2019 at 03:14:48PM +0200, Ard Biesheuvel wrote: > > On Wed, 29 May 2019 at 15:06, Leif Lindholm wrote: > > > > > > On Wed, May 29, 2019 at 02:50:19PM +0200, Ard Biesheuvel wrote: > > > > As opposed to the Secure96's I2C peripherals, whose bus addresses are > > > > properties of the peripherals themselves, the SPI CS address of the > > > > TPM is a property of the platform that incorporates the LS connector. > > > > > > > > So tweak the macros that emit the CS values and related properties > > > > to put it under the control of the platform that incorporates the > > > > driver. > > > > > > > > Signed-off-by: Ard Biesheuvel > > > > --- > > > > Platform/96Boards/Secure96Dxe/Secure96.dts | 2 +- > > > > Platform/96Boards/Secure96Dxe/Secure96.h | 11 ++++++++--- > > > > 2 files changed, 9 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts > > > > index d066fcb1933c..0d7d9b3900a4 100644 > > > > --- a/Platform/96Boards/Secure96Dxe/Secure96.dts > > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts > > > > @@ -39,7 +39,7 @@ > > > > __overlay__ { > > > > INFINEON_SLB9670_DT_NODENAME { > > > > compatible = "infineon,slb9670"; > > > > - reg = ; > > > > + reg = ; > > > > spi-max-frequency = <22500000>; > > > > }; > > > > }; > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.h b/Platform/96Boards/Secure96Dxe/Secure96.h > > > > index c34fc5eea046..1d8bf4159209 100644 > > > > --- a/Platform/96Boards/Secure96Dxe/Secure96.h > > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.h > > > > @@ -1,6 +1,6 @@ > > > > /** @file > > > > > > > > - Copyright (c) 2018, Linaro, Ltd. All rights reserved.
> > > > + Copyright (c) 2018-2019, Linaro, Ltd. All rights reserved.
> > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > > > @@ -8,14 +8,19 @@ > > > > #ifndef _SECURE96_H_ > > > > #define _SECURE96_H_ > > > > > > > > +#define __CONCAT(a,b) a ## b > > > > + > > > > > > Urgh. We badly need to properly add some official macros for this. > > > You could possibly use __CONCATENATE from Base.h. > > > > > > > OK, I'll use that instead. > > With that, for 1-4/5: > Reviewed-by: Leif Lindholm > Thanks Pushed as c587c76bec49..f36ee841e0ec