From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C5662095AE53 for ; Thu, 24 Aug 2017 11:25:44 -0700 (PDT) Received: by mail-io0-x22d.google.com with SMTP id g33so944754ioj.3 for ; Thu, 24 Aug 2017 11:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HRRQJ3PWKaPQYDLVKA2qqPrQ/V/iDNWksUlNTNiJ5sY=; b=CtipL2YXbxm6vdcqUob7CYnySqiEfiAoTd1TphE3pNcQC5l7q0E/iuF/6/da41ILC1 v3ch81c3NU/VXx5DHcP0YiPgbuRYbXkqfrTPqAiKKm9/DQIw6EBiBx0+lR3O6+CMEJcA tKir5M0ucQQnuFSdKcH3JRGAu1yKtfDH2FrNY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HRRQJ3PWKaPQYDLVKA2qqPrQ/V/iDNWksUlNTNiJ5sY=; b=WM0zd84v8DRYM02wFSp9rLn4YdLwbl4kZbLRlN8dYGO2hzIZqq8X3H3pXTLDHZjIED WFr4IHF2yyyS0Tny9qgL5rUwUjGYFnJZRaXDipCDRSTs2e4yhip0bcABv/ZP60kHezzm zBn3gPFMzFX4LR4wz2LlUB/z8ZseUwZog/pQaPUeffM/cDdar7yTtTkbNBF86p9nuhEr 0lkdfin0h5w6jW/fB+rnSnkU7vV5BmMm99s4TF1EdwiAtKOOXE6hF04JSMiB+2m5IONG LmkUIbpreXe4h0n+Cpl8wNY5zSYLBdH6Pjc4Wxv68vtUuN7ov3rkg6azz4+2F12d1Pep zkig== X-Gm-Message-State: AHYfb5hwSQyYmeNs+jccGp8SD/TtMj+y2fHqxzBG+eVATTE2g5iqH3oE Hs4C+zrvq9ScpUVi56UGrNoas1cJ9IDR X-Received: by 10.107.132.83 with SMTP id g80mr4144650iod.149.1503599298710; Thu, 24 Aug 2017 11:28:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Thu, 24 Aug 2017 11:28:18 -0700 (PDT) In-Reply-To: <20170824162153.23494-1-leif.lindholm@linaro.org> References: <20170824162153.23494-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 24 Aug 2017 19:28:18 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Michael D Kinney Subject: Re: [PATCH] Platform/Silicon: clean up BeagleBoard cargo culting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 18:25:44 -0000 Content-Type: text/plain; charset="UTF-8" On 24 August 2017 at 17:21, Leif Lindholm wrote: > A group of Pcd settings have been copied around ARM platforms from the > original BeagleBoardPkg, which > 1) Used Ebl. > 2) Was designed to minimise image size. > > None of the affected platforms _use_ Ebl, and all of them could benefit > from keeping ComponentName*Protocol information around, so remove these > overrides and build with default settings. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 22 ---------------------- > Platform/Marvell/Armada/Armada.dsc.inc | 22 ---------------------- > Silicon/Hisilicon/Hisilicon.dsc.inc | 23 ----------------------- > 3 files changed, 67 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index f2a05e8e6..12ce5ad96 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -280,23 +280,6 @@ > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > - > - # > - # Control what commands are supported from the UI > - # Turn these on and off to add features or save size > - # > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE > - > gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress > @@ -312,7 +295,6 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !endif > > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"VExpress" > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|1000000 > @@ -356,10 +338,6 @@ > # DEBUG_ERROR 0x80000000 // Error > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F > > - gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 > - > # > # Optional feature to help prevent EFI memory map fragments > # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 4e8f289fc..7e5c55c05 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -208,23 +208,6 @@ > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > - > - # > - # Control what commands are supported from the UI > - # Turn these on and off to add features or save size > - # > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE > - > gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > # Use the Vector Table location in CpuDxe. > @@ -250,7 +233,6 @@ > gArmPlatformTokenSpaceGuid.PcdDefaultConOutPaths|L"VenHw(D3987D4B-971A-435F-8CAF-4967EB627241)/Uart(115200,8,N,1)/VenPcAnsi()" > gArmPlatformTokenSpaceGuid.PcdDefaultConInPaths|L"VenHw(D3987D4B-971A-435F-8CAF-4967EB627241)/Uart(115200,8,N,1)/VenPcAnsi()" > > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"Marvell>> " > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|1000000 > @@ -323,10 +305,6 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F > !endif > > - gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 > - > # > # Optional feature to help prevent EFI memory map fragments > # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index a48c4773a..dd7fa6a3d 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -238,25 +238,6 @@ > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > - > - # > - # Control what commands are supported from the UI > - # Turn these on and off to add features or save size > - # > - ## Set PcdEmbeddedMacBoot to FALSE, or console mode will be changed when > - ## entering EBL and not restored when exiting. > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|FALSE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE > - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE > - > gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress > @@ -273,7 +254,6 @@ > [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Versatile Express" > > - gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"VExpress" > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|44 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0 > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > @@ -316,9 +296,6 @@ > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000004 > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06 > - gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|"" > - gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 > - gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 > > # > # Optional feature to help prevent EFI memory map fragments > -- > 2.11.0 >