public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Jan Dąbroś" <jsd@semihalf.com>,
	"Grzegorz Jaszczyk" <jaz@semihalf.com>,
	"Jici Gao" <Jici.Gao@arm.com>, "Tian, Feng" <feng.tian@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS
Date: Mon, 29 Apr 2019 15:35:52 +0200	[thread overview]
Message-ID: <CAKv+Gu8eAVvdW_Ot3dQ7_yLh++-fbSX0aJ934ktg1Fq+Sy437w@mail.gmail.com> (raw)
In-Reply-To: <1556356592-8614-1-git-send-email-mw@semihalf.com>

On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Latest change allowed to add dependency on NvVarStoreFormattedLib
> for the DXE_DRIVER modules. Although effectively it is hooked
> using the 'NULL' class, extend the LIBRARY_CLASS with according
> type for consistency sake.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 038f929c921c..e2d3a25f1a31

Thanks!

> ---
>  EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> index 98a0049..e2eed26 100644
> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> @@ -25,7 +25,7 @@
>    FILE_GUID                      = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> +  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
>    CONSTRUCTOR                    = NvVarStoreFormattedInitialize
>
>  [Sources]
> --
> 2.7.4
>

  reply	other threads:[~2019-04-29 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27  9:16 [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS Marcin Wojtas
2019-04-29 13:35 ` Ard Biesheuvel [this message]
2019-04-29 15:18   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu8eAVvdW_Ot3dQ7_yLh++-fbSX0aJ934ktg1Fq+Sy437w@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox