From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=PwJFC73r; spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by groups.io with SMTP; Mon, 29 Apr 2019 06:36:06 -0700 Received: by mail-it1-f193.google.com with SMTP id x132so16174853itf.2 for ; Mon, 29 Apr 2019 06:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jo1xpNqVYtyGYWbIaFYhd1PyORvTuUzaWKj/jcrdmgc=; b=PwJFC73rs5VcwNXLYIX8Dx6BG8kGNrdgcA7inGbH/9khDrh+6bnGSRTxr+KsEBC43R rrlZXzguVlk7ogkXOiKa4bHs/ApdsnD0PNvmG1pXT6EZ84fLGW6qb+CY1ofHLrI6BoY8 3kYx8uzIV4U1bNMLgKj59S4R8h906oauTC98gB8XB1Pr5+8Bx3L/2rcU8ThoAd3NZoOa xd0dOtL2K5bEPuH058NosLMaLdMzXH6WVbYzcAi2Jfpg40/m+OU4mNHUo9XfyBPyEWJ9 XXzHuRPtCgCpr82yQP5afnJ7ZzDgFTBqu+ccUKC/3jaaezXH2wgfuSb+xxxIQDpX2eIJ r4OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jo1xpNqVYtyGYWbIaFYhd1PyORvTuUzaWKj/jcrdmgc=; b=cw0Vvo6/pLATrA4tMeqqvX4ohIvQHpAZOYI+Cf9ZaK1xk9LtpsnDLcd6SafkNkGD9D FVTs5ZX0BVppK6xdy5dxCRgBshVMoaLtPW9HWmigblyp+6VttMxI68NlPjsquqKdCE3b w0QeyYTF5sL70Sc7V+uySvxRBfZKLQ6dKReCa+37nQQVV09BPmRY5n45stRF5jxgtgiJ ff/nIoWn6LXKplzTyrYx9IvHLGJePQsU5LwIE13ZJjx1IyObsKRhhOQgECjfW9tL88S0 554NO43mC9gofR1xGkc14Qjb/6CxUkvzOW8LUAic6ypjL7dS4JFc6kdGjjl53z3uTBhA BK1g== X-Gm-Message-State: APjAAAVWH6AwD+SHwWaZ6BapkTqsJRWjuo5lEIpxh/4wsFuvhAVnfiTs 2253ypC1Ai/sMgFJ9KDu4skvYe109InQndtPabvNsg== X-Google-Smtp-Source: APXvYqxQCsxavdjh7HbLxyVawFvR6EDKqnt9AvjColYRfT0lnPzFn0JN2AEVflMc5RyQZpQLhyzSRVogwTXPtO77hNM= X-Received: by 2002:a24:b342:: with SMTP id z2mr14022910iti.121.1556544965457; Mon, 29 Apr 2019 06:36:05 -0700 (PDT) MIME-Version: 1.0 References: <1556356592-8614-1-git-send-email-mw@semihalf.com> In-Reply-To: <1556356592-8614-1-git-send-email-mw@semihalf.com> From: "Ard Biesheuvel" Date: Mon, 29 Apr 2019 15:35:52 +0200 Message-ID: Subject: Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Jici Gao , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas wrote: > > Latest change allowed to add dependency on NvVarStoreFormattedLib > for the DXE_DRIVER modules. Although effectively it is hooked > using the 'NULL' class, extend the LIBRARY_CLASS with according > type for consistency sake. > > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as 038f929c921c..e2d3a25f1a31 Thanks! > --- > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > index 98a0049..e2eed26 100644 > --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > @@ -25,7 +25,7 @@ > FILE_GUID = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3 > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > + LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER > CONSTRUCTOR = NvVarStoreFormattedInitialize > > [Sources] > -- > 2.7.4 >