From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::230; helo=mail-it0-x230.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A2FD220D4BFC for ; Wed, 15 Nov 2017 05:32:16 -0800 (PST) Received: by mail-it0-x230.google.com with SMTP id u132so1766505ita.0 for ; Wed, 15 Nov 2017 05:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=c3EzI+iNQcQGCgfDiM0MOIZu4dTY5vHqcHfjF4Cz4TE=; b=bJi3cdwY5Do5B/FhQ7VxxhGY44Hz+k1VLSIEFxPnSN2lRc5l3IoFttzDaqAuoTpaTz 4zdPuvCNG7utVdJ0PSEUkxgP9jkWwV7xfDzIGC6sUtuqKH417nH+yIB5gk+81iANMwDJ 9FdDHZdByAlciXA5Y+g1YoAt0n+otAvKO6RrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=c3EzI+iNQcQGCgfDiM0MOIZu4dTY5vHqcHfjF4Cz4TE=; b=QrexSf8WI6sS/qc957+ZXl1cMWUhwmwEeKB7vQu458fn7nZ9JF3MX+xXOYhtComtH9 yGINYohWtwinLTCk94GPE1jhEZFpuNVrh9fsxLK3XNxtWcgExUxB3ozz8wlzNj8iRUjJ 0zxYiK4uBdWt162Px76jlsTdUneqDtlkRSBLd2O9H6gZhid3hE/qMtu0aHiSoLGJhmI+ oAVjGae85cjnhGmQ/+/HeNz8Glgz57XIt4Vzqksh2zZJAwj4EfzYGwy3YaDRCs3E3r0s BJXmNeES2uUgD6uAK8EzkJMkO4dBkzPc7OgYoNuzdUYXca+JoRT6TjqEjfZu7DJ9nuya GMHQ== X-Gm-Message-State: AJaThX6oZ1/HDrldZiZIGtJC/6mM3JE+7oMRPy1iOk+TZF8P2wEwNhdB 13xbhiFZnakKg19HfdEWXBmIj3OF6kR7FZtyeYSUtJZ3GdY= X-Google-Smtp-Source: AGs4zMZ4OitmoU1R9LZ4bGLLY9yfatowwLSZRer/e06gHND5BQl9oAb/7YIGSlz2HFzxGPekkpYK/xMmSzp5iSdfnwo= X-Received: by 10.36.145.203 with SMTP id i194mr19562862ite.73.1510752984391; Wed, 15 Nov 2017 05:36:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.20 with HTTP; Wed, 15 Nov 2017 05:36:23 -0800 (PST) In-Reply-To: References: From: Ard Biesheuvel Date: Wed, 15 Nov 2017 13:36:23 +0000 Message-ID: To: Udit Kumar Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: Why we need CapsuleLib even platform does not support this feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 13:32:16 -0000 Content-Type: text/plain; charset="UTF-8" On 15 November 2017 at 13:34, Udit Kumar wrote: > Hi, > I recently noticed in my build as well, we need to include CapsuleLib even platform does not support Capsule update feature. > Thanks to help me, why this dependency is added in edk2. > It was added as a dependency to ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf, for capsule update support. >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, November 14, 2017 4:48 PM >> To: Kalyan Nagabhirava >> Cc: edk2-devel@lists.01.org; Leif Lindholm ; Mark >> Gregotski >> Subject: Re: [edk2] [PATCH edk2-platforms]: resolving Hikey platform build error >> >> On 14 November 2017 at 11:16, Kalyan Nagabhirava >> wrote: >> > >> > "Instance of library class [CapsuleLib] is not found" build error is >> > coming for Hikey platform, to resolve this issueadded CapsuleLib to >> > "LibraryClasses.common" section >> > >> > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc >> > b/Platform/Hisilicon/HiKey/HiKey.dsc >> > index 968e8ac..2e3b1c8 100644 >> > --- a/Platform/Hisilicon/HiKey/HiKey.dsc >> > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc >> > @@ -61,6 +61,7 @@ >> > >> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroni >> > SynchronizationLib|zationLib.inf >> > >> > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf >> > + >> > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull. >> > + inf >> > >> > >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM >> an >> > UefiBootManagerLib|agerLib.inf >> > >> > >> PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformB >> > PlatformBootManagerLib|ootManagerLib.inf >> > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> > >> > >> >> Thanks Kalyan >> >> Could you resend it as a proper patch, please? I.e., with the appropriate >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> and Signed-off-by line, >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01 >> .org%2Fmailman%2Flistinfo%2Fedk2- >> devel&data=02%7C01%7Cudit.kumar%40nxp.com%7Cc1807332add6499fcd730 >> 8d52b516fad%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6364625 >> 51151191358&sdata=joABHCm%2F3Iu0jfplBE3Ora9ffp3IfuNuu2GfOgOTsV8%3D >> &reserved=0