From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=w6vqqd1X; spf=pass (domain: linaro.org, ip: 209.85.166.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by groups.io with SMTP; Mon, 24 Jun 2019 04:15:27 -0700 Received: by mail-io1-f67.google.com with SMTP id m24so760154ioo.2 for ; Mon, 24 Jun 2019 04:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KtD8e49uRKBIAZZroOEjWHqT8jirahRtknO6FXP266I=; b=w6vqqd1XQQ/YnBKPstiOLotrsmWTgJy2pWyvI5ykP2WVt7oucF0CpF3uMuabtTKn1+ 6ndvV5r3UlCJjOeXlYJOn6F2xT39OFP/GEDtWRsWPBz5ZyrlUr7yypV+ZWsmvQ4N2u/B Zyw4/pmSAeQrKJcQ9u7Ob38kR42b5qZiQ37Y3ey9qkWfsB6ONGHTbhulbxiWxj57vvOs Jxt3hEfq4bDDgR3vmvwBaTyAlmvYKSMyYerW2tVdNJkLb/ux5aMKIzYlPu7kyCEzEUvX bjsAV8bP43Wi9cSnOLY0wtLe9gSyw5z7Twdp0CJmhs9Tc4FhLqMJvqW540ECqlS0br+f jzvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KtD8e49uRKBIAZZroOEjWHqT8jirahRtknO6FXP266I=; b=e/MnuZjzbi2Mh3xUyRriz8CD4cOIHekb6R0UsB7RWI8JahiF5LZNBkpTQZAmZo4Ip/ 5vtBLuzHESMLlLK4mIPA3q5t1/eyG8vPbMu3ljHDdze8LXlJ+vlIje7dSvWeQ5ocZzbM 2NfBncmBHvB+2jo76RxMHa3vkdphDUHseVOqt2DsVlcEwS7q7BSoPjj7Zf7ROZOJGGJf rKp6cUkxyE6IwFX4zjv8rlCQq78r4tgf88hblhq9fFYGqzYoPE9ey3UTjrYCn74LhbT0 mF/P8LtQpmuVaTAiVfj7mglN+SfLNdZjf1OYdGgj5QLjwcTsZp1mdbFBDPJ3MLsM32zL tqAw== X-Gm-Message-State: APjAAAWhh/mnmZi9KjJLDVQR3oi6v2+GumBRLy10RxSEBw6IoR4QgkRZ L1aPRtiIFN0Db1UAZoSXAtTyreMLAn01sEUqhktLnA== X-Google-Smtp-Source: APXvYqzX1fnwqKUGOYEmEGva4kFBcuQ/UMOEfao9E+wKqT7D8nRJR0uPjG75bj39qdpA7X2E29UE20ZGOH74lrARUUc= X-Received: by 2002:a5d:9d83:: with SMTP id 3mr6494942ion.65.1561374926672; Mon, 24 Jun 2019 04:15:26 -0700 (PDT) MIME-Version: 1.0 References: <65b0c09f4296451484f671223fe6b6af@ukex01.SolarFlarecom.com> In-Reply-To: <65b0c09f4296451484f671223fe6b6af@ukex01.SolarFlarecom.com> From: "Ard Biesheuvel" Date: Mon, 24 Jun 2019 13:15:14 +0200 Message-ID: Subject: Re: [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds To: Tomas Pilar Cc: Devel EDK2 , "jordan.l.justen@intel.com" , "lersek@redhat.com" Content-Type: text/plain; charset="UTF-8" On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: > > Switching to this library enables capsule support for FMP devices. Simple > tests show that a capsule with an embedded driver now updates using > CapsuleApp. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Tomas Pilar I don't have a problem with this change unless it affects the code size considerably. However, isn't this only useful for updating the firmware on PCI cards from within a VM when they are passed through from the host to the guest? I understand this is a useful test scenario for you, but at least clarify this in the commit log. > --- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 39ac791565..4c41e59a75 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -125,7 +125,7 @@ > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > - CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > -- > 2.17.2 >