From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D244F21E74907 for ; Fri, 1 Sep 2017 04:12:09 -0700 (PDT) Received: by mail-io0-x22e.google.com with SMTP id 81so14108357ioj.5 for ; Fri, 01 Sep 2017 04:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4TBzSHGlXJP7dlJ+4z1hDCvV73T3TEfexyYkVIQNllA=; b=cNmJVkwxuBXo2Xt3qxG4x8povdmW7MlxdgVmsbZXjQhEB4CKSg2U4KOeHE6/Kx3vdC wYC/9CUc87FnknybDudyBbPi3TCLBAWCahiDpIaw+d1h2vAYMIWMXUrrj92ERKKeBVde 0f6NttNMVRiDqwquNlg0J6zruPJw+gmWMg7Vk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4TBzSHGlXJP7dlJ+4z1hDCvV73T3TEfexyYkVIQNllA=; b=LrRmBdui167EnwgGyMfKPjNwOw0SjSulXlfM886mQIPx9pawnjxlg8otOpDvmoxWgS jWNm2S39k7ANtiWWc2bUjwSJurNzzSVJnQGGgXLLplCtg4rT1eo9YLFS1bxV0oC3QkAo UjFCv+GsYUTbkas/N2wYrgwvCPB0FONHxKHsDRI6COnp9wQ9tWQgUdNZr89RzgKgTK4o T7rr2R40sGIz3LAnWOsO7lElOUsCLrFni2uJO7AFer91KyHLYunuMglv5eJ33+bmE3ps 2f7pFrc4w/to9Fw/mnENY6aP3OBdM6q9AqxqNOpddyeyqCr46rBKfWuY6P1UMcGmYqPT GXTA== X-Gm-Message-State: AHPjjUgAaV1tcy4X6c4jfGvIyc2h6jd2CCArl9kqp4dBTn47Aii/F/+0 xzQw89S3RQ6K8gGdpzBMSnPQb93fN6YJbl8= X-Google-Smtp-Source: ADKCNb4O35X6D3Wdr1LbkXFCgWpDPdWuHwqiREnPbZyIWHfSSMHDd/MG5y/EylRgSOzS4rou78fQou+s4hJPYzw8qdA= X-Received: by 10.36.178.80 with SMTP id h16mr247547iti.128.1504264493686; Fri, 01 Sep 2017 04:14:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 04:14:53 -0700 (PDT) In-Reply-To: <20170901111200.z2vr5iijgxj2hgy6@bivouac.eciton.net> References: <20170831130830.12833-1-ard.biesheuvel@linaro.org> <20170831130830.12833-3-ard.biesheuvel@linaro.org> <20170901111200.z2vr5iijgxj2hgy6@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 12:14:53 +0100 Message-ID: To: Leif Lindholm Cc: Alan Ott , "edk2-devel@lists.01.org" , Grant Likely Subject: Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 11:12:10 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 12:12, Leif Lindholm wrote: > Adding Grant, > > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote: >> Clean up the device tree source file, by switching to Tianocore >> conventions for line endings and whitespace etc, and by replacing >> open coded values with symbol constants and/or phandle references. > > 1: All for the getting rid of open coding. > > 2: As for the line endings/whitespace, I am less convinced. > > It is its own (and very specific) file format, it is not > edk2-specific, and just like (GNU)Makefiles and shellscripts they > originated in a CR-free environment. > Yeah, that's a good point actually. Ideally, we'd just import this mythical, separate DT repository that is disjoint from the kernel entirely.