From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=RDWrGwEh;
 spf=pass (domain: linaro.org, ip: 209.85.166.66, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66])
 by groups.io with SMTP; Thu, 13 Jun 2019 04:42:42 -0700
Received: by mail-io1-f66.google.com with SMTP id k20so16096512ios.10
        for <devel@edk2.groups.io>; Thu, 13 Jun 2019 04:42:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=keW4uWl2anaIACcTykmUSN96M2rUMZHQICWx8nJO4Xs=;
        b=RDWrGwEh1FD5/4k9eXHSzBI7X+mhb/1IHQbbvma0Rt2sdfIZH781tjMBg5ErOc6umI
         FUOB2FFoOISQa1sIxRx3lcb/4JEJUj95NR3zoWTobn9PLUH1xsymRyEWsFHAcQ/1RjKM
         gYHlbPr6aEprudWnwALVfUqnDsLxeCbnTmJbcL2vyBem/3Am5UT6jxOny9MPi80hf5EF
         s8YgWp7XzhawkEiBDBUoLTKjLy1/Yp8dLjVkWLooH23OiGeIynEiJyzTitD9T2anDY9M
         0fbBdIX7VkqmTIGuSkZl3DgtVNmuIfMW1x0zO5mM8IRvYiQIHahBbp2bIADjguZtxNGE
         fdQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=keW4uWl2anaIACcTykmUSN96M2rUMZHQICWx8nJO4Xs=;
        b=p1lmEM9itYy9R4lHBorO8apNtstvoGOs28LFW+WsdRyUQnn8aGXjIgzcK+r8yozypj
         8hCqvBeWMF2iVch/g7axCJhZ8bIPzSCBTwwBZSznPIzVGAWAfRUhfejuxHzOTV/IPVH5
         AzCaWulVhD33Xm0A12pjqxa6xAgQVJKhHDJfFzMbVqKKo3wZchUh/mWVAZXZPzOa40Fu
         rXSq5PedAhy1oeF3Xn5QpcVQJEkym2C6mc+QUMIWC+qeYLXJfQuX3Wu5jmH41dHVux2W
         y7QrbZkh20QAJgGFGHOiqi5g7eVEbFf3wDRH5cUq7zitqWBJEjoRdiw9zIRM6T0FxOwD
         bbCg==
X-Gm-Message-State: APjAAAU/Koevu2Uh+CiRwgzjkaTRXZuHOav8ppLZFIhAqe/vCRCPiMAb
	dyPw2g9reh5DfCLlR8P7nm9fwpKdHdbl0KpOp7C9lA==
X-Google-Smtp-Source: APXvYqy8dhJ53SVpYdPitI/esZziwzW1nZP6xg3RtfhRojU2SdVFL6JaoB6Bj0JyUHakIpm0HPoUEqrOzvuBwsnmSh0=
X-Received: by 2002:a5d:9d83:: with SMTP id 3mr48594209ion.65.1560426161800;
 Thu, 13 Jun 2019 04:42:41 -0700 (PDT)
MIME-Version: 1.0
References: <20190613114152.32671-1-leif.lindholm@linaro.org>
In-Reply-To: <20190613114152.32671-1-leif.lindholm@linaro.org>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 13 Jun 2019 13:42:29 +0200
Message-ID: <CAKv+Gu8gSfXEwNK9-DdyFySYb5EXpsu2qhTNxC=Mg0AmjwQjsg@mail.gmail.com>
Subject: Re: [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Thu, 13 Jun 2019 at 13:41, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> The migration of OptionRomPkg to edk2-platforms broke the HiKey build.
> Update the paths in .dsc/.fdf to restore.
>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/HiKey/HiKey.dsc | 2 +-
>  Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index c785af6e69..bcbe4fafce 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -246,7 +246,7 @@ [Components.common]
>    #
>    # AX88772 Ethernet Driver
>    #
> -  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> +  Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
>
>    #
>    # FAT filesystem + GPT/MBR partitioning
> diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf
> index 2b2e3ad053..33fa0da208 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.fdf
> +++ b/Platform/Hisilicon/HiKey/HiKey.fdf
> @@ -158,7 +158,7 @@ [FV.FvMain]
>    #
>    # AX88772 Ethernet Driver for Apple Ethernet Adapter
>    #
> -  INF OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> +  INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
>
>    #
>    # FAT filesystem + GPT/MBR partitioning
> --
> 2.11.0
>