From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.448.1585591038025022202 for ; Mon, 30 Mar 2020 10:57:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Gb6Xx2Mg; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id i19so2667801wmb.0 for ; Mon, 30 Mar 2020 10:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k21WKBBst/sgDNrQAGiISkEefC6ON2QmN8gFOdw8Ans=; b=Gb6Xx2Mg9VxJOrClprQt3MzGE/Lu//aEpbCQ+CttGhbh/FCm8inA0sefytVF+RrDJA C8G7vT5MDCXfuBgsPFyAqZ8fBYYUnRy3IyhAqSTzhG1648oqlEXGLAcVjUjUof8wsf3I m1Wcd33d5G+qQFeaLXWIWl32HnoekLYGQdeqy8siMerjYaeIiFCHADDT2mb7LZBZ48G7 euGGrMqLgRSlrguG5gHDsYSPgTxr4eugvq48EnZsmyS4rhUp785ZtfTo5Fk3I0oQSj07 FFTCoPaBvX9FhtieUb9ur2GPvRdVbQ2ESbtv7k1D3AcznUz13RJklV41/0ceuXaiWBRn 3Vkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k21WKBBst/sgDNrQAGiISkEefC6ON2QmN8gFOdw8Ans=; b=bE/bANfi97Mwz211BRNwxUgLvyQnbny41bHD15WZ4yzcOIVxK2opvoeU8i7Wq6p5lu xsd1amjJXA+iBaGaJe7HDcHBIex4J6X4FX1hLRH3e1jlsiq239ZwsktZiHyFsoeSB5RQ FiXwcCHKKYeSgU9AUvio8L4mKMIJB8MmdBtXnaUhMfwHA4ZT48hASUGeyskxikz8o0jo GRgW/Zk1q4tfIneEK/hhzXyMP0wV43fOsLIKdmGZa9XXVG6VYjnKiLp9Eph7j5YOR22m +wcChSYnFzhhRvsrSN2FcIbv895/F4zVcnnF1lgAwA371bmnhUTQThnUTWRmMG+oq8o+ s61Q== X-Gm-Message-State: ANhLgQ1bgYCy5k5bYYN79Y70mhGHTHZDfB+3oePstwqgPQ3oSZoA+zCm EZlQlO7W/ZbnuyrI+1PZfcx2pXI7HQiFdpDFI92Skg== X-Google-Smtp-Source: ADFU+vtNy1cOTCwdVTi/VMPeYO3tOIvUry4PmrPzpj6+UoKwMEiIOvaJJvtlrSywaTbcRgpKlGegN5vwA9g03qV8sM0= X-Received: by 2002:a7b:cb81:: with SMTP id m1mr441665wmi.1.1585591036620; Mon, 30 Mar 2020 10:57:16 -0700 (PDT) MIME-Version: 1.0 References: <20200326102443.748-1-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503F9A0997@shsmsx102.ccr.corp.intel.com> <216623fab6344881b9958359a1d99f80@intel.com> In-Reply-To: <216623fab6344881b9958359a1d99f80@intel.com> From: "Ard Biesheuvel" Date: Mon, 30 Mar 2020 19:57:05 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table To: "Gao, Liming" , "Wu, Hao A" , Jian J Wang Cc: "devel@edk2.groups.io" , "Yao, Jiewen" , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Ni, Ray" , Bret Barkelew Content-Type: text/plain; charset="UTF-8" (adding Jian and Hao) Thanks for the acks, and apologies for failing to cc the MdeModulePkg maintainers. Jian, Hao, do you have any opinion on this series? On Mon, 30 Mar 2020 at 15:42, Gao, Liming wrote: > > Ack-by: Liming Gao > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > > Sent: Friday, March 27, 2020 1:01 PM > > To: Ard Biesheuvel ; devel@edk2.groups.io > > Cc: Laszlo Ersek ; Leif Lindholm ; Kinney, Michael D ; Ni, Ray > > ; Bret Barkelew > > Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table > > > > Acked-by: Jiewen Yao > > > > I cannot remember if there is windows OS still using the properties table. > > Maybe Microsoft people can comment. > > > > If no, I agree we can remove the old code. > > > > > > > > > -----Original Message----- > > > From: Ard Biesheuvel > > > Sent: Thursday, March 26, 2020 6:25 PM > > > To: devel@edk2.groups.io > > > Cc: Ard Biesheuvel ; Laszlo Ersek > > > ; Leif Lindholm ; Kinney, Michael D > > > ; Ni, Ray ; Yao, Jiewen > > > ; Bret Barkelew > > > Subject: [PATCH 0/4] remove generation of EFI properties table > > > > > > The EFI properties table is broken by design, deprecated, and seems to be > > > causing confusion as it is unclear to some how it differs from the memory > > > attributes table (which supersedes it). So let's get rid of the code that > > > generates it entirely, along with the GUID definitions, PCDs etc. > > > > > > Due to how the two implementations are intertwined, patch #2 makes the > > > minimal changes required to stop producing the table (and to allow patch > > > #3 to remove the associated definitions from MdePkg). Patch #4 is optional > > > and merges the code together. > > > > > > Cc: Laszlo Ersek > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Ray Ni > > > Cc: Jiewen Yao > > > Cc: Bret Barkelew > > > > > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633 > > > > > > Ard Biesheuvel (4): > > > OvmfPkg: remove handling of properties table > > > MdeModulePkg: disable properties table generation but retain the code > > > MdePkg: remove PropertiesTable GUID > > > MdeModulePkg/DxeCore: merge properties table routines into MAT > > > handling > > > > > > MdeModulePkg/Core/Dxe/DxeMain.h | 9 - > > > MdeModulePkg/Core/Dxe/DxeMain.inf | 3 - > > > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 1 - > > > .../Core/Dxe/Misc/MemoryAttributesTable.c | 1226 ++++++++++++++- > > > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - > > > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1373 ----------------- > > > MdeModulePkg/MdeModulePkg.dec | 24 - > > > MdeModulePkg/MdeModulePkg.uni | 21 - > > > MdePkg/Include/Guid/PropertiesTable.h | 31 - > > > MdePkg/MdePkg.dec | 3 - > > > OvmfPkg/OvmfPkgIa32.dsc | 1 - > > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > > > OvmfPkg/OvmfPkgX64.dsc | 1 - > > > OvmfPkg/OvmfXen.dsc | 1 - > > > OvmfPkg/PlatformPei/Platform.c | 1 - > > > OvmfPkg/PlatformPei/PlatformPei.inf | 1 - > > > 16 files changed, 1222 insertions(+), 1476 deletions(-) > > > delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c > > > delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h > > > > > > -- > > > 2.17.1 > > > > > > >