From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts
Date: Wed, 28 Feb 2018 09:17:37 +0000 [thread overview]
Message-ID: <CAKv+Gu8gu-hrfc37ojsfRYi8EWNr4t-FNqD73UFGv3JzOhQcRQ@mail.gmail.com> (raw)
In-Reply-To: <20180227200627.4optrpsxnt3ct6lz@bivouac.eciton.net>
On 27 February 2018 at 20:06, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote:
>> Even though the Secure96 device tree source is strictly an overlay, we
>> managed to express it in a way that does not rely on unresolved symbols
>> and other tricks that are only implemented in fairly recent versions of
>> the device tree compiler, and so adding the /plugin/ directive is not
>> only unnecessary, it is harmful because it is only understood by those
>> same recent compiler versions. So remove it.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as f90743b8813518fd7111c272ea4a3483a94ed462
>> ---
>> Platform/96Boards/Secure96Dxe/Secure96.dts | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts
>> index b56ce59985cc..a221bdf9bbec 100644
>> --- a/Platform/96Boards/Secure96Dxe/Secure96.dts
>> +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts
>> @@ -22,7 +22,6 @@
>> #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0
>>
>> /dts-v1/;
>> -/plugin/;
>>
>> / {
>> fragment@0 {
>> --
>> 2.11.0
>>
prev parent reply other threads:[~2018-02-28 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 18:26 [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts Ard Biesheuvel
2018-02-27 20:06 ` Leif Lindholm
2018-02-28 9:17 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8gu-hrfc37ojsfRYi8EWNr4t-FNqD73UFGv3JzOhQcRQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox