From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3E067223522BA for ; Wed, 28 Feb 2018 01:11:31 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id v6so2455038iog.7 for ; Wed, 28 Feb 2018 01:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zqm4dCUU5jRKl82xqXqk32Ckt1jQFQpG3TSIQqyTuRg=; b=gohNUuj+HfU3kQXkagkVPASGgzUL2DrQ3AaWOMOTjfMZR3hFt0//02qBSYKfai86LH H+g0hOvRJciJ0sSxXEcrCWz9m0HK4sMmxmyzc02k+IJaLOfGHELC7YIT+wFC8O68RYVO fcdYr7gzYWMgfOTHg4BxONq8N8b4VON6gr3mY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zqm4dCUU5jRKl82xqXqk32Ckt1jQFQpG3TSIQqyTuRg=; b=cALXyAaFUQp2j0RjUUL0CdTCM03SguiZueJ9Y6m1mWWqt2J0cZOiWVU8jD34WkbEgT vPfRGIbdv/q+NicfnUlzbhnDgh6BMZY1+F+X6E9L+ITvz4T/k8k21+SunwHMeBfxWKaL 7U+u9uo/wNM7uGEVYqDyhRhikc9DfGJpO5I/kbSfDpT1pRd/TaLZGDbjWD7bMRIrkvzW kfoLYKyjUhKwSeu6obs+Ev2r8N8rhWiK/qKASC2LCYvA58vn9YOS7PWAngTWAL6gOwvs pPg6o6ZgBKS/CTuHD630zd2zTDm5B4e4yJfb8OYneu2EX7Tbym1ZWeMUCO7WwZV56x6R 631g== X-Gm-Message-State: APf1xPC8K31LtUWfbnU1FhN1nErMFUEvnHrP9Uhv3MQIBay9M/ANt/qb io0u+WJci70MnqKh4NrlMZtJP1zN9dXA5NHjBKloI840UG8= X-Google-Smtp-Source: AG47ELudbs61ROb0JsLfjwCwqdeLmCFh2WbLsEktSp/NyNLs22CIckiuEgRdqGGdcyiTo2f3zzzhlSIActE3MGYp0eE= X-Received: by 10.107.56.69 with SMTP id f66mr19137166ioa.170.1519809458417; Wed, 28 Feb 2018 01:17:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 28 Feb 2018 01:17:37 -0800 (PST) In-Reply-To: <20180227200627.4optrpsxnt3ct6lz@bivouac.eciton.net> References: <20180227182619.6973-1-ard.biesheuvel@linaro.org> <20180227200627.4optrpsxnt3ct6lz@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 28 Feb 2018 09:17:37 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 09:11:32 -0000 Content-Type: text/plain; charset="UTF-8" On 27 February 2018 at 20:06, Leif Lindholm wrote: > On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote: >> Even though the Secure96 device tree source is strictly an overlay, we >> managed to express it in a way that does not rely on unresolved symbols >> and other tricks that are only implemented in fairly recent versions of >> the device tree compiler, and so adding the /plugin/ directive is not >> only unnecessary, it is harmful because it is only understood by those >> same recent compiler versions. So remove it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as f90743b8813518fd7111c272ea4a3483a94ed462 >> --- >> Platform/96Boards/Secure96Dxe/Secure96.dts | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts >> index b56ce59985cc..a221bdf9bbec 100644 >> --- a/Platform/96Boards/Secure96Dxe/Secure96.dts >> +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts >> @@ -22,7 +22,6 @@ >> #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0 >> >> /dts-v1/; >> -/plugin/; >> >> / { >> fragment@0 { >> -- >> 2.11.0 >>