From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D9032244E3EE for ; Sun, 15 Apr 2018 22:40:42 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id k8so5848551ioc.2 for ; Sun, 15 Apr 2018 22:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qWW/l0UEoPdhwZQ+o8aXTBfoVKE0LMLxw6YY89XAJxE=; b=HAbv3tXWYsLMdWn6z3w05RF40cSjzQ6bpqNKdF4CLI1bG+SwJKWcal9QjwIuXMEsQq eAXf+mmA01lJPeXDhMxGq/ZwxJGNRL3lCOm88uyX09m9nINNMYeHxojr5vKHAVWFcSCN tONWAFR3Xxg+xKgnR62e00uNnhqUzWhxfGhzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qWW/l0UEoPdhwZQ+o8aXTBfoVKE0LMLxw6YY89XAJxE=; b=TgtYM1TSbc37sDSDif9w07013gMO4HmY3GaJA6f4OrCj62KhEcR57/d/cBnvZyyKBd 6+A9CbTR1bZJomgx1dv21QBL0YVYJfmhez9C00zKjXhw0DaP4GybYrlFp//Cx8fqGoS9 PKX7eH3PiK9qx0IKeaYEWq01FO2StzL6WXpdBWvsSZE3Kf26P2z7yDNdenuG1MRwwdrb LfOStVrXNddeKO9h6XClFJlSX/pFSVh8qiATbeBmxVQ9mC+tYEXgdM678BN7LKaxoLIW OSgiU9woSFU/wzpuyNavBzfw0TQJqGujlBoBzE1FzxcT2SdyINS62fgSHEAWNmutKhlt YTBw== X-Gm-Message-State: ALQs6tBuBA18tQp7IYO4H7sBUxrxrsUwi3HAHqiKbsbyrss5q/CSVZo1 5hGY/uULoSBuONNt5viNH4uyd135IyC0d0nfqkWlug== X-Google-Smtp-Source: AIpwx4/PE0PgYXD1cVxxBIsglR/fRQ6me27ZGQPdruZKMDwFj623TBYVTyP5WMoUgrh7EoWcf42xdbRyasdM0flAf9E= X-Received: by 10.107.217.15 with SMTP id r15mr22991593ioc.107.1523857240020; Sun, 15 Apr 2018 22:40:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Sun, 15 Apr 2018 22:40:39 -0700 (PDT) In-Reply-To: <1523855353-9262-3-git-send-email-mw@semihalf.com> References: <1523855353-9262-1-git-send-email-mw@semihalf.com> <1523855353-9262-3-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Mon, 16 Apr 2018 07:40:39 +0200 Message-ID: To: Marcin Wojtas , Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms PATCH 2/2] Marvell/Armada: RealTimeClockLib: Depend on gEfiCpuArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 05:40:42 -0000 Content-Type: text/plain; charset="UTF-8" On 16 April 2018 at 07:09, Marcin Wojtas wrote: > Recent changes in the EDK2 mainline resulted in breaking > RTC functionality of Armada platforms. > > The RealTimeClockLib instance calls gDS->SetMemorySpaceAttributes() > in the LibRtcInitialize() public function. This DXE service depends > on the CPU Arch Protocol. Add it to the depex. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel > --- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > index 2f842e8..59c71c4 100644 > --- a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > +++ b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf > @@ -25,7 +25,7 @@ > FILE_GUID = fa81e889-045b-4c96-9093-742554fd0588 > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = RealTimeClockLib > + LIBRARY_CLASS = RealTimeClockLib|DXE_RUNTIME_DRIVER > > [Sources.common] > RealTimeClockLib.c > @@ -50,3 +50,6 @@ > > [Pcd] > gMarvellTokenSpaceGuid.PcdRtcEnabled > + > +[Depex.common.DXE_RUNTIME_DRIVER] > + gEfiCpuArchProtocolGuid > -- > 2.7.4 >