From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::233; helo=mail-io0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E1F2220E8DF5 for ; Thu, 26 Apr 2018 09:10:04 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id t23-v6so18725937ioc.10 for ; Thu, 26 Apr 2018 09:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BWiApr7SgZG0VRG6ekdbrFxn1xEPb39n6nIKIAN/+u0=; b=hTjc2oflB2fGYf7LgeVm3NDTgWW2VV3SRdqXDGceRenngu6vQYa0zOHdljlJK97hp7 wJvjAaPxZju8ujl9KrAfrwfwh6Le91QMoGx8iouSbWFNRC6bHOcirXPqn/Tpk3rTxUi5 FGOhbO9AdK5KfuRXxyBTdbVxRGWb8vZsT2nGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BWiApr7SgZG0VRG6ekdbrFxn1xEPb39n6nIKIAN/+u0=; b=IcIBbJaBPTOXzSdKCKc5tqwd5RDIUfQu++nW2uXMJCeNy/ijX10lATCnJUdE/XyINO XdDNo7ryuItUpns2b/dM9hUvk7pxw2/knsOJ1Qt2KqQxoPtCr6wmoRpeEZxt5R43GQ/9 vCaVmCvk/MiiJs/ofY3shVAhOPhS3XV90Fatwvc7IruEK2zS4qCwGtkQkIGf1YDf5qWU ogomkXEHYkYpR37dHDBSQsMQQXMyYOMWN0wbHRB3emtRGtkZA/mn+G1zTbKQgd5c25aT GKLuLOq5X8OJjC/twfS8iDVECjcUTJYQT7/utRwiWzO99IlwouWiFmPRD0wTmR3Zd7DH vHfA== X-Gm-Message-State: ALQs6tC44YwrRdG0ufB8RULPOwmm+3OTndAip097WsyH/L5ojPQ6zC1q 3KWlQM9raf+Tc/IS9Ffz1wo3NaJnQjoMuw/uN/s+i1BC X-Google-Smtp-Source: AB8JxZqcxNExSoFEpBDqcNyDIytRQ7X+iMXvbJUfQfzpi7euM+BTXWpQchEYnaqSwetBMVP+NpHg5BgHJf71pBgSejA= X-Received: by 2002:a6b:268b:: with SMTP id m133-v6mr12892697iom.107.1524759003992; Thu, 26 Apr 2018 09:10:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.134 with HTTP; Thu, 26 Apr 2018 09:10:02 -0700 (PDT) In-Reply-To: <20180426154106.131664-3-sami.mujawar@arm.com> References: <20180426154106.131664-1-sami.mujawar@arm.com> <20180426154106.131664-3-sami.mujawar@arm.com> From: Ard Biesheuvel Date: Thu, 26 Apr 2018 18:10:02 +0200 Message-ID: To: Sami Mujawar Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Matteo Carlini , Stephanie Hughes-Fitt , nd , "Kinney, Michael D" , "Gao, Liming" , Evan Lloyd Subject: Re: [PATCH v1 2/2] MdePkg: IORT Specification Rev D updates X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 16:10:05 -0000 Content-Type: text/plain; charset="UTF-8" On 26 April 2018 at 17:41, Sami Mujawar wrote: > Updated IORT structure definitions to conform to the IO Remapping > Table, Platform Design Document, Revision D, March 2018. > > The following structures have been updated: > 1. SMMUv3 - fix on proximity node. > 2. PMCG - added page 1 support. > 3. Root complex node - added DMA mask (memory address size limit). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Reviewed-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/253_iort_update_v1 > > Notes: > v1: > - Updated for IORT Specification Revision D. [SAMI] > > MdePkg/Include/IndustryStandard/IoRemappingTable.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > index 2e5cb45d7e2ffd4a0559ef706b71874843e3fdbd..389f352c2fbc725e5e9a881a73adc306035dc0de 100644 > --- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h > +++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > @@ -1,7 +1,7 @@ > /** @file > - ACPI IO Remapping Table (IORT) as specified in ARM spec DEN0049C > + ACPI IO Remapping Table (IORT) as specified in ARM spec DEN0049D > > - http://infocenter.arm.com/help/topic/com.arm.doc.den0049c/DEN0049C_IO_Remapping_Table.pdf > + http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf > > Copyright (c) 2017, Linaro Limited. All rights reserved.
> Copyright (c) 2018, ARM Limited. All rights reserved.
> @@ -123,6 +123,8 @@ typedef struct { > > UINT32 AtsAttribute; > UINT32 PciSegmentNumber; > + UINT8 MemoryAddressSize; > + UINT8 Reserved1[3]; > } EFI_ACPI_6_0_IO_REMAPPING_RC_NODE; > > /// > @@ -185,8 +187,7 @@ typedef struct { > UINT32 Pri; > UINT32 Gerr; > UINT32 Sync; > - UINT8 ProximityDomain; > - UINT8 Reserved1[3]; > + UINT32 ProximityDomain; > UINT32 DeviceIdMappingIndex; > } EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE; > > @@ -199,6 +200,7 @@ typedef struct { > UINT64 Base; > UINT32 OverflowInterruptGsiv; > UINT32 NodeReference; > + UINT64 Page1Base; > //EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE OverflowInterruptMsiMapping[1]; > } EFI_ACPI_6_0_IO_REMAPPING_PMCG_NODE; > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >