From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7BF40211D07A2 for ; Wed, 6 Mar 2019 07:18:04 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id k21so10489361ior.13 for ; Wed, 06 Mar 2019 07:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m7dCWMKA55OwpGXxUV3LSvUhGVicnL3S2obpt1VR06I=; b=OTfi+q1+MG0jf5CyICyunRBz1iGvEGl5reepibIup+KZCAuouIhV5+3CjVdChg1KIq QuJ+Oa8K3LYbUW1F3BFri/atU8lfNapcd33nTQp0mReMQK9MZiLaTSl4A+D/Y1HZOa55 pd+u9ipylzgFfBhWTO5iUJ0RTvh8Ja2Ea+tgtWiFtS/B0ktyE9FavU1USwgabfxlXCp5 68BqvBJY25KfvWLNPZl+U75X2huIxDnSbAtVUHVktQzoALGQaMqxyiW9P+SVWCYFwaal yMmsarKnccPRo8M9hg1suLMKMuQpcqscMcfPZeN0LIBnodxsykawWcXRh/nQnJyKXfje 6O4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7dCWMKA55OwpGXxUV3LSvUhGVicnL3S2obpt1VR06I=; b=SnqFN01JarHELHCvJQOkuynaY7mZkefYF/ATvEcYYTZr59fAQwH30LQAqWpoq6JskK AXzGKWoDe7oMf2dO31jJFtK8Kv42T4FQSZN5uKm+U2+pcj/TB7/rmJm5AZVDKVIdplyP vqOtHpen9PzDKl0y9qTBg2JJ6b6BLJzidCftQt0pF8HExtgW7oqQbewh9Dss+jlW5GWL qInQ6NmYGwdpmcnZvYZ7IcPxoSgv9trx7WD68xHwUh5VDhE9yGFpEdD6XBsRHjC9WKRL 4Shi0wbU7+Q2FseKRZxZUBuWZgGWL6Tw669vznOlcVdSE5VI1Sw+3CBMBlsmSQbrunFt QoNQ== X-Gm-Message-State: APjAAAXJW7rmYkmcQBDwvyPILzERihTB4N1YRia+gbCbfVsmBbblkJqT jGXyEkrLHYJ12XrfvO9wlmCTI3ocjv2KzPtdLoTqPoSO X-Google-Smtp-Source: APXvYqwhLzaWh6ev7hxAKi3pXzCBE66qmUyrS2bRX3hSx7FhQNX3wFR4q5Oo7CcesqM4et7QUcUmGZVJi3ZZpByjAYI= X-Received: by 2002:a5e:d609:: with SMTP id w9mr3299711iom.170.1551885483544; Wed, 06 Mar 2019 07:18:03 -0800 (PST) MIME-Version: 1.0 References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> <20190306151639.GN21602@mac-ubuntu-vm> In-Reply-To: <20190306151639.GN21602@mac-ubuntu-vm> From: Ard Biesheuvel Date: Wed, 6 Mar 2019 16:17:51 +0100 Message-ID: To: Achin Gupta Cc: "edk2-devel@lists.01.org" , Supreeth Venkatesh , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , nd Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 15:18:04 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > Hi Ard, > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > first place since the value is implied by the context (it is never > > valid to set it to FALSE for standalone MM or TRUE for traditional > > MM). So drop it. > > This is being used to determine if the ArmVExpressPkg should include support for > StMM comm. buffer or not [1] but it does look redundant now. > If that is the case, the PCD should be defined in that package.