From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Ye, Ting" <ting.ye@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Wei, Gang" <gang.wei@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
Achin Gupta <achin.gupta@arm.com>,
Jagadeesh Ujja <jagadeesh.ujja@arm.com>
Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules
Date: Mon, 21 Jan 2019 13:40:39 +0100 [thread overview]
Message-ID: <CAKv+Gu8iZ+YUxET5sv_XL4eNEDNUi5Ore2OMFn0SqpPtrz1NDg@mail.gmail.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3BF4FF@SHSMSX104.ccr.corp.intel.com>
On Mon, 21 Jan 2019 at 13:40, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
> Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough.
>
OK, thanks!
> Thanks
> Liming
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Monday, January 21, 2019 8:36 PM
> > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Cc: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Wei, Gang
> > <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A
> > <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja
> > <jagadeesh.ujja@arm.com>
> > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules
> >
> > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote:
> > > >
> > > >
> > > >
> > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> > > >
> > >
> > > Ting, do you have any objections to this patch?
> > >
> >
> > Ping?
> >
> >
> >
> > > >
> > > > > -----Original Message-----
> > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > > > > Sent: Thursday, January 17, 2019 5:22 AM
> > > > > To: edk2-devel@lists.01.org
> > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting
> > > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J
> > > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
> > > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star
> > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja
> > > > > <jagadeesh.ujja@arm.com>
> > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE
> > > > > modules
> > > > >
> > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > ---
> > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > > index c34699cd62bf..a681fe2f36b8 100644
> > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > > @@ -30,7 +30,7 @@ [Defines]
> > > > > MODULE_TYPE = DXE_SMM_DRIVER
> > > > > VERSION_STRING = 1.0
> > > > > PI_SPECIFICATION_VERSION = 0x0001000A
> > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE
> > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE
> > > > > MM_STANDALONE
> > > > >
> > > > > #
> > > > > # The following information is for reference only and not required by the build
> > > > > tools.
> > > > > --
> > > > > 2.17.1
> > > >
next prev parent reply other threads:[~2019-01-21 12:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 21:22 [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel
2019-01-16 21:22 ` [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules Ard Biesheuvel
2019-01-18 7:05 ` Wang, Jian J
2019-01-18 11:12 ` Ard Biesheuvel
2019-01-21 12:36 ` Ard Biesheuvel
2019-01-21 12:40 ` Gao, Liming
2019-01-21 12:40 ` Ard Biesheuvel [this message]
2019-01-22 2:42 ` Ye, Ting
2019-01-16 21:22 ` [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: " Ard Biesheuvel
2019-01-18 7:06 ` Wang, Jian J
2019-01-18 11:13 ` Ard Biesheuvel
2019-01-18 15:01 ` Yao, Jiewen
2019-01-16 21:22 ` [PATCH 3/4] MdeModulePkg/VarCheckLib: " Ard Biesheuvel
2019-01-18 7:06 ` Wang, Jian J
2019-01-18 8:15 ` Zeng, Star
2019-01-18 10:45 ` Zeng, Star
2019-01-16 21:22 ` [PATCH 4/4] MdePkg/UefiDevicePathLib: " Ard Biesheuvel
2019-01-18 11:07 ` Ard Biesheuvel
2019-01-21 12:37 ` Gao, Liming
2019-01-21 12:43 ` [PATCH 0/4] Various Packages: add MM_STANDALONE support Ard Biesheuvel
2019-01-21 12:49 ` Gao, Liming
2019-01-21 14:34 ` Ard Biesheuvel
2019-02-28 14:53 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8iZ+YUxET5sv_XL4eNEDNUi5Ore2OMFn0SqpPtrz1NDg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox