From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A947C210DF5C0 for ; Tue, 7 Aug 2018 13:53:01 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id d70-v6so166372ith.1 for ; Tue, 07 Aug 2018 13:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=noOe7/HMS1RLne3lrG8H+O8xpcl+yygrnmbb6zUQwA8=; b=cFvR/Df/vyMOXhAaAZP6eqgP0Dg19cD+eNp82lQO/dm6xLO1jM89xJqIKc+IEZ5Mfx h0/kCqE4FidAH62oO3DW8KAQGVY6dvQduhNap4zJP1njIAO3X1YQ+OUG6q/9ruXpbqIS 9iL2ShLQ+nEKCQFUPE4/qVKKrDOR7jVPPiWvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=noOe7/HMS1RLne3lrG8H+O8xpcl+yygrnmbb6zUQwA8=; b=iqJpNVV/i9XS/N6qOQyhiAlHh1aEHSAhMCywl6wyzj2/rGMnLpj23gODZjhl2hPcXq 3TYhQxS6roSdOzkJlPcl/YYUc7mHi/wt8nsviUwRX8mKb2XjMTgCvLe4PUlXHtr5rlg6 1xefFH/aKnHTYmCxjKa8EY248wotjfKxCyvXvj+DaDPlFIfhLpIw+Wi7RaUb34cJvNZ9 PfWPK35LVNIXYbexQd8CEyJ4fEDzufB9uAdM++irdlNEAJGb3IUIZsEs79JWZKTnVPMz YQSfHn7KSOZoghcL9su0sdUEMYxue68bhJJGb7FyaElLx5GZ2sy1GRHIVEkyJiUMYlc+ I5BQ== X-Gm-Message-State: AOUpUlG56d+qmFK7mO1kRqn2KsxSGNGMtLmzT21/JXnkwjIwt5Bsfrfo 7fWnhnMHhlqM4rt3FjIonsXvoCL46qhGye7Z+Rad5Q== X-Google-Smtp-Source: AA+uWPyW0zxoUZjucq9osID3W86WmLZsgv2IciFJvYHtUpB3e7l5YYIg0vt8g5I0Hf9GP/Wqf16skvAGawX+TIJ7Myw= X-Received: by 2002:a24:610d:: with SMTP id s13-v6mr30165itc.68.1533675180264; Tue, 07 Aug 2018 13:53:00 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Tue, 7 Aug 2018 13:52:59 -0700 (PDT) In-Reply-To: <20180807205112.2008-1-leif.lindholm@linaro.org> References: <20180807205112.2008-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Tue, 7 Aug 2018 22:52:59 +0200 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ming Huang Subject: Re: [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 20:53:01 -0000 Content-Type: text/plain; charset="UTF-8" On 7 August 2018 at 22:51, Leif Lindholm wrote: > edk2 commit 1010873becc5, > ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the > d0x build, since they use their own PlatformBootManagerLib, which did not > include this function. > > Implement a trivial one, that just returns. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > > NOTE: The upstream build is currently broken. This failure needs to be > addressed before d02 deletion and d03 fix can go in. > > Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c b/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > index 7dd5ba615c..aa6db929ca 100644 > --- a/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > @@ -641,3 +641,19 @@ PlatformBootManagerWaitCallback ( > 0 > ); > } > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to applications > + built into firmware volumes. > + > + If this function returns, BDS attempts to enter an infinite loop. > +**/ > +VOID > +EFIAPI > +PlatformBootManagerUnableToBoot ( > + VOID > + ) > +{ > + return; > +} > -- > 2.11.0 >