Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers.

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Mon, 30 Dec 2019 at 15:16, Jared McNeill <jmcneill@invisible.ca> wrote:
>
> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
> and the Broadcom SDHost uses GIC SPI 120.
>
> Signed-off-by: Jared McNeill <jmcneill@invisible.ca>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as cc7a0c68618c..314c45bc620b

(apologies - in my haste, I forgot to add Pete's R-b and Phil's Ack
given down-thread)

> ---
>  Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> index 57ee411a61..56d15c3927 100644
> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> @@ -33,7 +33,7 @@ Device (SDC1)
>      Name (RBUF, ResourceTemplate ()
>      {
>        MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,)
> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x5E }
> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x9E }
>      })
>      Return (RBUF)
>    }
> @@ -76,7 +76,7 @@ Device (SDC2)
>      Name (RBUF, ResourceTemplate ()
>      {
>        MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,)
> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x58 }
> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x98 }
>      })
>      Return (RBUF)
>    }
> --
> 2.21.0 (Apple Git-122.2)
>
>
> 
>